This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
toolchain: allow to configure build_tar target #1937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current behavior of
build_tar
tool used bycontainer_layer
is not hermetic, because it implicitly depends on the python toolchain, and as demonstrated by #1680, this can lead to non-reproducible builds.What is the new behavior?
Similar to #1881, this PR adds an optional attribute for toolchain configuration, allowing to pass a hermetic
build_tar_target
executable.Does this PR introduce a breaking change?