Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

toolchain: allow to configure build_tar target #1937

Merged
merged 3 commits into from
Dec 6, 2021

Commits on Oct 4, 2021

  1. DockerToolchainInfo.build_tar_target support

    python/cpython#18080 hasn't been back-ported to python3.8, which happens to be
    the default interpreter version in a lot of popular base docker images.
    
    This change in python's tarfile implementation affects the behavior of
    https://github.com/bazelbuild/rules_docker/blob/bdea23404dd256c7ae2f8e02d346428044cc7d91/container/archive.py#L144
    used by a popular container_image rule. This means that images built by bazel
    in environments with different python3 versions will result in different image
    digests.
    
    Until the hermeticity of python toolchains is guaranteed, it may be useful to
    have a workaround for users who can provide their own build_tar tool, akin to
    https://github.com/kubernetes/repo-infra/blob/72a6f5d05659f7d255b51f152e0725adfe970718/tools/build_tar/buildtar.go
    dataoleg committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    a514e95 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Configuration menu
    Copy the full SHA
    6a2fef8 View commit details
    Browse the repository at this point in the history
  2. add test

    dataoleg committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    36b0473 View commit details
    Browse the repository at this point in the history