Skip to content

Commit

Permalink
sdk: symlink everything under lib/ when using local SDK (#3074)
Browse files Browse the repository at this point in the history
We rely on the packaged zoneinfo zip in CRDB, found under
lib/time/zoneinfo.zip. When using the remote SDK macro, we untar the
entire archive into the sandbox. When pointing to a local SDK however,
we previously ignored everything under lib. It feels reasonable to also
symlink lib/ into the sandbox given they have valid symbols to build
against.

We needed this patch in order to build CRDB with local go installations.

+cc cockroachdb/cockroach#56178
  • Loading branch information
irfansharif committed Mar 15, 2022
1 parent b682cd0 commit 8553d97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/private/sdk.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def _remote_sdk(ctx, urls, strip_prefix, sha256):
)

def _local_sdk(ctx, path):
for entry in ["src", "pkg", "bin"]:
for entry in ["src", "pkg", "bin", "lib"]:
ctx.symlink(path + "/" + entry, entry)

def _sdk_build_file(ctx, platform):
Expand Down

0 comments on commit 8553d97

Please sign in to comment.