sdk: symlink everything under lib/ when using local SDK #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on the packaged zoneinfo zip in CRDB, found under lib/time/zoneinfo.zip. When using the remote SDK macro, we untar the entire archive into the sandbox. When pointing to a local SDK however, we previously ignored everything under lib. It feels reasonable to also symlink lib/ into the sandbox given they have valid symbols to build against. We needed this patch in order to build CRDB with local go installations. +cc cockroachdb/cockroach#56178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on the packaged zoneinfo zip in CRDB, found under
lib/time/zoneinfo.zip. When using the remote SDK macro, we untar the
entire archive into the sandbox. When pointing to a local SDK however,
we previously ignored everything under lib. It feels reasonable to also
symlink lib/ into the sandbox given they have valid symbols to build
against.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
See commit message.
Which issues(s) does this PR fix?
No filed issue.
Other notes for review