Skip to content

Commit

Permalink
Update tests ahead of Go 1.11 (#1661)
Browse files Browse the repository at this point in the history
A test in the old version of org_golang_x_crypto we were testing fails
with Go 1.11. This is fixed in newer versions.
  • Loading branch information
jayconrod committed Aug 15, 2018
1 parent ebb0ab7 commit ec70e26
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
5 changes: 4 additions & 1 deletion tests/integration/popular_repos/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,25 @@ test_suite(
tests = [
"@org_golang_x_crypto//acme:go_default_test",
"@org_golang_x_crypto//acme/autocert:go_default_test",
"@org_golang_x_crypto//argon2:go_default_test",
"@org_golang_x_crypto//bcrypt:go_default_test",
"@org_golang_x_crypto//blake2b:go_default_test",
"@org_golang_x_crypto//blake2s:go_default_test",
"@org_golang_x_crypto//blowfish:go_default_test",
"@org_golang_x_crypto//bn256:go_default_test",
"@org_golang_x_crypto//cast5:go_default_test",
"@org_golang_x_crypto//chacha20poly1305:go_default_test",
"@org_golang_x_crypto//chacha20poly1305/internal/chacha20:go_default_test",
"@org_golang_x_crypto//cryptobyte:go_default_test",
"@org_golang_x_crypto//curve25519:go_default_test",
"@org_golang_x_crypto//ed25519:go_default_test",
"@org_golang_x_crypto//hkdf:go_default_test",
"@org_golang_x_crypto//internal/chacha20:go_default_test",
"@org_golang_x_crypto//internal/subtle:go_default_test",
"@org_golang_x_crypto//md4:go_default_test",
"@org_golang_x_crypto//nacl/auth:go_default_test",
"@org_golang_x_crypto//nacl/box:go_default_test",
"@org_golang_x_crypto//nacl/secretbox:go_default_test",
"@org_golang_x_crypto//nacl/sign:go_default_test",
"@org_golang_x_crypto//ocsp:go_default_test",
"@org_golang_x_crypto//openpgp:go_default_test",
"@org_golang_x_crypto//openpgp/armor:go_default_test",
Expand Down
5 changes: 4 additions & 1 deletion tests/integration/popular_repos/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,25 @@ This runs tests from the repository `golang.org/x/crypto <https://golang.org/x/c

* @org_golang_x_crypto//acme:go_default_test
* @org_golang_x_crypto//acme/autocert:go_default_test
* @org_golang_x_crypto//argon2:go_default_test
* @org_golang_x_crypto//bcrypt:go_default_test
* @org_golang_x_crypto//blake2b:go_default_test
* @org_golang_x_crypto//blake2s:go_default_test
* @org_golang_x_crypto//blowfish:go_default_test
* @org_golang_x_crypto//bn256:go_default_test
* @org_golang_x_crypto//cast5:go_default_test
* @org_golang_x_crypto//chacha20poly1305:go_default_test
* @org_golang_x_crypto//chacha20poly1305/internal/chacha20:go_default_test
* @org_golang_x_crypto//cryptobyte:go_default_test
* @org_golang_x_crypto//curve25519:go_default_test
* @org_golang_x_crypto//ed25519:go_default_test
* @org_golang_x_crypto//hkdf:go_default_test
* @org_golang_x_crypto//internal/chacha20:go_default_test
* @org_golang_x_crypto//internal/subtle:go_default_test
* @org_golang_x_crypto//md4:go_default_test
* @org_golang_x_crypto//nacl/auth:go_default_test
* @org_golang_x_crypto//nacl/box:go_default_test
* @org_golang_x_crypto//nacl/secretbox:go_default_test
* @org_golang_x_crypto//nacl/sign:go_default_test
* @org_golang_x_crypto//ocsp:go_default_test
* @org_golang_x_crypto//openpgp:go_default_test
* @org_golang_x_crypto//openpgp/armor:go_default_test
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/popular_repos/popular_repos.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ def popular_repos():
go_repository,
name = "org_golang_x_crypto",
importpath = "golang.org/x/crypto",
strip_prefix = "crypto-81e90905daefcd6fd217b62423c0908922eadb30",
strip_prefix = "crypto-de0752318171da717af4ce24d0a2e8626afaeb11",
type = "zip",
urls = ["https://codeload.github.com/golang/crypto/zip/81e90905daefcd6fd217b62423c0908922eadb30"],
urls = ["https://codeload.github.com/golang/crypto/zip/de0752318171da717af4ce24d0a2e8626afaeb11"],
)
_maybe(
go_repository,
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/popular_repos/popular_repos.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
dict(
name = "org_golang_x_crypto",
importpath = "golang.org/x/crypto",
urls = "https://codeload.github.com/golang/crypto/zip/81e90905daefcd6fd217b62423c0908922eadb30",
strip_prefix = "crypto-81e90905daefcd6fd217b62423c0908922eadb30",
urls = "https://codeload.github.com/golang/crypto/zip/de0752318171da717af4ce24d0a2e8626afaeb11",
strip_prefix = "crypto-de0752318171da717af4ce24d0a2e8626afaeb11",
type = "zip",
excludes = [
"ssh/agent:go_default_test",
Expand Down

0 comments on commit ec70e26

Please sign in to comment.