Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgo_library doesn't pass copts down to cgo #119

Closed
ecaraszi opened this issue Sep 28, 2016 · 3 comments
Closed

cgo_library doesn't pass copts down to cgo #119

ecaraszi opened this issue Sep 28, 2016 · 3 comments
Labels

Comments

@ecaraszi
Copy link

ecaraszi commented Sep 28, 2016

Hello,

Thanks for making rules_go! Here's a small bug report & potential fix:

Bug: cgo_binary doesn't pass copts down to the compiler flags in the cgo invocation.

Fix: github.com/ecaraszi/rules_go on branch cflags

I used this patch to successfully build the github.com/go-gl libraries (glfw 3.2, gl 4.1-core, and mathgl) and link a working example.

@yugui yugui added the bug label Sep 28, 2016
@pmbethe09
Copy link
Member

We welcome contributions, so please make a PR

On Wed, Sep 28, 2016 at 1:12 AM, ecaraszi notifications@github.com wrote:

Hello,

Thanks for making rules_go!

cgo_binary doesn't pass copts down to the compiler flags in the cgo
invocation.

I made a patch on github.com/ecaraszi/rules_go branch bazelbuild, which I
then used to successfully build the github.com/go-gl libraries (glfw 3.2,
gl 4.1-core, and mathgl) and link a working example.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#119, or mute the thread
https://github.com/notifications/unsubscribe-auth/ALF-0qvZjyz1FOVB1naOqraK2uS6Wesyks5qufdZgaJpZM4KIa-t
.

@jmhodges
Copy link
Contributor

(Sorry, just poking around in other cgo tickets. This maybe can be closed again now?)

@jayconrod
Copy link
Contributor

Closing old issues. Seems like this one is fixed.

groodt pushed a commit to groodt/rules_go that referenced this issue Mar 14, 2022
…y) (bazelbuild#119)

Faster comparisons and IMO cleaner feeling overall.
It doesn't affect behaviour in any way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants