-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: cannot test //:authors_sorted_test
with the Windows-native test wrapper
#2034
Comments
jayconrod
pushed a commit
that referenced
this issue
Apr 19, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes #2034
jayconrod
pushed a commit
that referenced
this issue
May 8, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes #2034
jayconrod
pushed a commit
that referenced
this issue
May 8, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes #2034
jayconrod
pushed a commit
that referenced
this issue
May 8, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes #2034
blico
pushed a commit
to blico/rules_go
that referenced
this issue
May 10, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes bazelbuild#2034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of rules_go are you using?
What version of gazelle are you using?
What version of Bazel are you using?
0.25.0rc3 from https://releases.bazel.build/0.25.0/rc3/bazel-0.25.0rc3-windows-x86_64.exe
Does this issue reproduce with the latest releases of all the above?
No: the latest Bazel release (0.24.0) does not yet support the Windows-native test wrapper.
What operating system and processor architecture are you using?
Windows 10, x86_64
Any other potentially useful information about your toolchain?
What did you do?
What did you expect to see?
The test to pass.
It does with
--noincompatible_windows_native_test_wrapper
(the default):What did you see instead?
The test failed:
The text was updated successfully, but these errors were encountered: