Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support optimized vs debug builds #741

Closed
ldemailly opened this issue Aug 18, 2017 · 2 comments
Closed

support optimized vs debug builds #741

ldemailly opened this issue Aug 18, 2017 · 2 comments
Labels
enhancement

Comments

@ldemailly
Copy link

Could we make it so
bazel build -c opt
uses the optimizations for go compiler (basically today the default empty gcflags but maybe future go releases would have extra optimizations from the default)

While debug builds would have
-gcflags="-N -l"

(like c++ rules automatically tweak cc flags)
does that make sense ?
This was referenced Aug 18, 2017
Closed
Closed
ianthehat added a commit to ianthehat/rules_go that referenced this issue Aug 21, 2017
@ianthehat
Add debug compile flags
b8961cc 
Triggered when -c dbg is specified on the hazel command line.
Turns of inlining and optimizations
Fixes bazelbuild#741
@ianthehat ianthehat mentioned this issue Aug 21, 2017
Merged
@ianthehat
Copy link
Contributor

I put up a pull request with this feature over the weekend, if you want to try it you can get #743, and let me know if it does what you need.

ianthehat added a commit that referenced this issue Aug 28, 2017
@ianthehat
Add debug compile flags (#743)
7d6d6da 
Triggered when -c dbg is specified on the hazel command line.
Turns of inlining and optimizations
Fixes #741
@ldemailly
Copy link
Author

thanks a lot !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianthehat @ldemailly