Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths in error messages #2736

Merged
merged 3 commits into from
Dec 7, 2020

Commits on Nov 20, 2020

  1. relativize paths in error messages

    Before:
    
      /private/var/tmp/_bazel_robfig/1db08896ecff7e5e96a745981c3b77e6/sandbox/darwin-sandbox/28708/execroot/corp/gocode/src/corp/analytics/searchterms/redshiftcopier.go:14:2: imported and not used: "corp/net/rpc"
    
      compilepkg: nogo: errors found by nogo during build-time code analysis:
      /private/var/tmp/_bazel_robfig/1db08896ecff7e5e96a745981c3b77e6/sandbox/darwin-sandbox/29923/execroot/corp/gocode/src/corp/net/rpc/server.go:125:7: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
    
    After:
    
      gocode/src/corp/analytics/searchterms/redshiftcopier.go:14:2: imported and not used: "corp/net/rpc"
    
      compilepkg: nogo: errors found by nogo during build-time code analysis:
      gocode/src/corp/net/rpc/server.go:125:7: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
    
    Fixes bazelbuild#2061
    Rob Figueiredo committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    54df87e View commit details
    Browse the repository at this point in the history
  2. Address comments

    Rob Figueiredo committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    8c591bd View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Do not relativize in runAndLogCommandToFile

    Rob Figueiredo committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    93b9531 View commit details
    Browse the repository at this point in the history