Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v0.33.0 #3175

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 5, 2022

Release Notes

Breaking changes

Deprecations

  • The asm, compile, and pack action generators provided by go_context are deprecated and planned for removal in version v0.36.0. Please leave a comment on the tracking bug if archive and link are not suitable replacements for your use cases.

Bug Fixes

Thanks to all of the contributors!

Compatibility

The minimum required version of Bazel remains at 4.2.1.

Updated dependencies

  • Updated org_golang_x_sys, org_golang_x_xerrors, org_golang_google_genproto, go_googleapis to their most recent commit as of 2022-06-05

As always, you can use higher versions of rules_go's dependencies by declaring them in WORKSPACE before calling go_rules_dependencies. Lower versions may work but are not supported.

WORKSPACE code

// TBD after release

@fmeum fmeum marked this pull request as ready for review June 5, 2022 07:02
@fmeum fmeum marked this pull request as draft June 5, 2022 07:04
@fmeum fmeum changed the title Run upgrade-dep all for 0.33.0 Prepare release v0.33.0 Jun 5, 2022
@sluongng
Copy link
Contributor

sluongng commented Jun 5, 2022

Would be nice to get a gazelle release coupled with this. ❤️

@sluongng
Copy link
Contributor

sluongng commented Jun 5, 2022

Please leave a comment on the tracking bug if archive and link are not suitable replacements for you use cases.

s/you/your/

@fmeum fmeum marked this pull request as ready for review June 5, 2022 15:10
@fmeum fmeum marked this pull request as draft June 5, 2022 15:38
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 5, 2022

Will try to fix #3178 for this release.

@linzhp
Copy link
Contributor

linzhp commented Jun 5, 2022

Do you want to upgrade x_tools too? It's been while since last upgrade

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 5, 2022

I remember you saying something about gazelle having to update x_mod first. Has that been done?

@linzhp
Copy link
Contributor

linzhp commented Jun 5, 2022

yeah, but I am wondering whether we can make rules_go not relying on Gazelle's version of x_mod. If that's not possible, maybe we should upgrade x_mod in Gazelle and release a new version of Gazelle? It's been a while since last release.

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 5, 2022

That seems difficult - we would probably have to get it with a git_repository and patch in BUILD files. Should I also do the Gazelle release? I don't know the project well though.

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 6, 2022

Confirmed that Gazelle tests pass with rules_go at this PR with the latest commit fixing bzl_library deps.

@fmeum fmeum marked this pull request as ready for review June 6, 2022 12:49
@sluongng
Copy link
Contributor

sluongng commented Jun 6, 2022

just a small note: we should look into how to de-noise the *.patch files. All the diff seems to be just changing the time stamp in the generated diff which is not useful to review.

@linzhp linzhp merged commit 8a36282 into bazelbuild:master Jun 6, 2022
@sluongng
Copy link
Contributor

sluongng commented Jun 6, 2022

https://github.com/bazelbuild/rules_go/blob/master/go/tools/releaser/upgradedep.go#L539-L559 It seems like we do intended to sanitize the patch file from timestamp, but there is a bug that make it fail? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants