Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the unused compiling API #3168

Closed
achew22 opened this issue Jun 1, 2022 · 1 comment · Fixed by #3173
Closed

Deprecate the unused compiling API #3168

achew22 opened this issue Jun 1, 2022 · 1 comment · Fixed by #3173

Comments

@achew22
Copy link
Member

achew22 commented Jun 1, 2022

Tracking bug for deprecating the unused compiling API that was removed when Jay switched over to having all the compilation/linking. We are going to add print warning statements into the compile, compilePackage et al to ask people to come check in on this bug.

@fmeum
@fmeum fmeum mentioned this issue Jun 3, 2022
Merged
fmeum added a commit to fmeum/rules_go that referenced this issue Jun 3, 2022
@fmeum
Delete legacy actions API
6685848 
Fixes bazelbuild#3168
@fmeum fmeum mentioned this issue Jun 3, 2022
Merged
@fmeum
Copy link
Collaborator

fmeum commented Jun 3, 2022

Submitted #3172 to add deprecation warnings. #3173 is a CI test run to check that removing these actions is actually safe.

fmeum added a commit to fmeum/rules_go that referenced this issue Jun 3, 2022
@fmeum
Delete legacy actions API
df0fdc7 
Fixes bazelbuild#3168
@fmeum fmeum mentioned this issue Jun 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete legacy actions API fmeum/rules_go
2 participants
@achew22 @fmeum