Add support for go_binary to gopackagesdriver.
#3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in bazelbuild#3270, The current implementation of `bazel_json_builder` does not handle `go_binary` build rules. This means that when `gopackagesdriver` attempts to be used on a file that is apart of a `go_binary`, no build target is produced as the output of `bazel query`. This prevents downstream utilities (`gopls`) from being able to provide functionality such as autocompletion support. This PR simply adds `go_binary` as a supported rule type, fixing bazelbuild#3270.
fmeum
approved these changes
Aug 17, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR adds
go_binaryas a supported rule type, fixing a bug preventing features like autocomplete from working when using gopackagesdriver.Which issues(s) does this PR fix?
Fixes #3270
Other notes for review
As discussed in #3270, The current implementation of
bazel_json_builderdoes not handle
go_binarybuild rules. This means that whengopackagesdriverattempts to be used on a file that is apart of ago_binary, no build target is produced as the output ofbazel query.This prevents downstream utilities (
gopls) from being able to providefunctionality such as autocompletion support.
I didn't see any tests to update, but let me know if I missed something and I'm happy to make changes.