Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for go_binary to gopackagesdriver. #3271

Merged
merged 1 commit into from
Aug 17, 2022

Commits on Aug 17, 2022

  1. Add support for go_binary to gopackagesdriver.

    As discussed in bazelbuild#3270, The current implementation of `bazel_json_builder`
    does not handle `go_binary` build rules. This means that when
    `gopackagesdriver` attempts to be used on a file that is apart of a
    `go_binary`, no build target is produced as the output of `bazel query`.
    This prevents downstream utilities (`gopls`) from being able to provide
    functionality such as autocompletion support.
    
    This PR simply adds `go_binary` as a supported rule type, fixing bazelbuild#3270.
    DrewMonroe committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    4f9835d View commit details
    Browse the repository at this point in the history