fix(packages-driver): allow defining additional aspects instead #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erwriting the default
fmeum
reviewed
Oct 21, 2022
| @@ -119,11 +119,13 @@ func (b *BazelJSONBuilder) Build(ctx context.Context, mode LoadMode) ([]string, | |||
| return nil, fmt.Errorf("found no labels matching the requests") | |||
| } | |||
|
|
|||
| aspects := append(additionalAspects, rulesGoAspect) | |||
There was a problem hiding this comment.
AFAIK the order may be quite significant here.
@linzhp Is this the correct one (and if so, why?)?
There was a problem hiding this comment.
This was a syntax simplification assuming the order didn't matter, if it does I'd be happy to change it so rules_go is first.
There was a problem hiding this comment.
I'm not saying this order is wrong, I simply don't know the aspect well enough to decide this. If I understood the interaction correctly, the latter aspect would see providers added by the former, but maybe that's just not how it works. :-)
There was a problem hiding this comment.
If the additional aspects need some information from each other, or from the default aspect, they can specify required_providers in their aspect definition, then Bazel would run those aspect in the order to satisfy the requirement.
@JamyDev did you test the these aspects don't override each other when that have the same output group and provider?
There was a problem hiding this comment.
There is possibility for overlap if you output to the same .pkg.json file as the default aspect. The packagesdriver only considers the .pkg.json files, so long as there's no overlap in these files it's fine. In our (Uber's) case that's not a problem, we output to ruleName.pkg.json (just like the default aspect does) and only output anything when we encounter our custom rule.
Now if the order in the argument here is actually followed this means that if I write a bad custom aspect, it'll get overridden by the rulesGo aspect, unless I directly declare it as a required_provider.
linzhp
reviewed
Oct 21, 2022
Co-authored-by: Zhongpeng Lin <zplin@uber.com>
JamyDev
force-pushed
the
fix/make_aspects_additional
branch
from
99d451f
to
98d593e
Compare
linzhp
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Do you think there ever is a scenario where the goDefaultAspect is not wanted? If so, maybe we can instead have GOPACKAGESDRIVER_BAZEL_ASPECTS, which defaults to //go/tools/gopackagesdriver:aspect.bzl%go_pkg_info_aspect, and ask users to set it to //go/tools/gopackagesdriver:aspect.bzl%go_pkg_info_aspect,//some/other%aspect if they want aspects in addition to the default aspect, and set it to //some/other%aspect if they don't want to default aspect
Maybe but then we'd also have to define each of the go targets individually instead of only additional ones. At that point it might make sense to just fork GoPackagesDriver, no? |
|
yeah, that's right. |
renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Nov 23, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.35.0` -> `v0.36.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go</summary> ### [`v0.36.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.35.0...v0.36.0) #### Major new features The Go runfiles library developed by [@​phst](https://togithub.com/phst) at https://github.com/phst/runfiles is now available as `github.com/bazelbuild/rules_go/go/runfiles` (target `@io_bazel_rules_go//go/runfiles`) and is now the official way to look up runfiles from Go. It will be made compatible with Bzlmod in a future release. **Note:** For improved consistency with runfiles libraries in other languages, the `Path` function present in https://github.com/phst/runfiles is called `Rlocation` in rules_go. #### What's Changed - bzlmod: Use register_toolchains by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3290 - Remove unused env_execute by [@​kmicklas](https://togithub.com/kmicklas) in [bazelbuild/rules_go#3276 - Correctly forward InstrumentedFilesInfo from dependencies by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3294 - Parse Go SDK version out of `go version` instead of `VERSION` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3296 - also write test stderr to json (xml) output file by [@​rickystewart](https://togithub.com/rickystewart) in [bazelbuild/rules_go#3300 - Bzlmod: Pin Bazel version in CI by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3301 - Allow to select Go SDK version from declared SDKs by [@​ash2k](https://togithub.com/ash2k) in [bazelbuild/rules_go#3303 - Use top level VERSION file when it exists by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3309 - synchronize when writing to the JSON converter by [@​rickystewart](https://togithub.com/rickystewart) in [bazelbuild/rules_go#3311 - update version manifest URL by [@​benjaminp](https://togithub.com/benjaminp) in [bazelbuild/rules_go#3314 - Symlink "misc" into repository for local_sdk. by [@​adam-azarchs](https://togithub.com/adam-azarchs) in [bazelbuild/rules_go#3313 - Ensure compatibility with incompatible flags close to flipping by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3319 - Add additional bzlmod requirements to allow grpc protobufs to work by [@​shs96c](https://togithub.com/shs96c) in [bazelbuild/rules_go#3320 - bzlmod: Update pinned Bazel version by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3321 - bzlmod: Set up automated BCR releases by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3324 - bzlmod: Add support for gogo proto compiler by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3323 - gopackagesdriver: move non-Go files to OtherFiles (Fixes [#​3326](https://togithub.com/bazelbuild/rules_go/issues/3326)) by [@​michaelarusso](https://togithub.com/michaelarusso) in [bazelbuild/rules_go#3327 - bzlmod: Allow yanked versions in CI by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3329 - feat(pkg-drv): allow setting custom aspect and kinds by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3328 - fix(packages-driver): allow defining additional aspects instead by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3330 - Add support for parsing Go development versions by [@​zakcutner](https://togithub.com/zakcutner) in [bazelbuild/rules_go#3333 - Match GOARCH ppc64 to @​platforms//cpu:ppc as well. by [@​mahiuchun](https://togithub.com/mahiuchun) in [bazelbuild/rules_go#3336 - bzlmod: Update Publish to BCR app config by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3337 - gopackagesdriver: default to NotHandled:true for package queries by [@​ian-h-chamberlain](https://togithub.com/ian-h-chamberlain) in [bazelbuild/rules_go#3338 - fix(packagesdrv): resolve third party go packages by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3332 - runfiles: port phst/runfiles to rules_go by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3205 - Adding gc_linopts to command line flag by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3342 - Move new runfiles library to `//go/runfiles` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3341 - Rename `Path` to `Rlocation` in runfiles library by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3346 - Add 'gc_goopts' flag to command line to allow gc_goopts to propagate by [@​LWarrens](https://togithub.com/LWarrens) in [bazelbuild/rules_go#3340 #### New Contributors - [@​kmicklas](https://togithub.com/kmicklas) made their first contribution in [bazelbuild/rules_go#3276 - [@​adam-azarchs](https://togithub.com/adam-azarchs) made their first contribution in [bazelbuild/rules_go#3313 - [@​shs96c](https://togithub.com/shs96c) made their first contribution in [bazelbuild/rules_go#3320 - [@​michaelarusso](https://togithub.com/michaelarusso) made their first contribution in [bazelbuild/rules_go#3327 - [@​zakcutner](https://togithub.com/zakcutner) made their first contribution in [bazelbuild/rules_go#3333 - [@​mahiuchun](https://togithub.com/mahiuchun) made their first contribution in [bazelbuild/rules_go#3336 - [@​LWarrens](https://togithub.com/LWarrens) made their first contribution in [bazelbuild/rules_go#3340 **Full Changelog**: bazelbuild/rules_go@v0.35.0...v0.36.0 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "ae013bf35bd23234d1dea46b079f1e05ba74ac0321423830119d3e787ec73483", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.36.0/rules_go-v0.36.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.36.0/rules_go-v0.36.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.19.3") </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cgrindel/swift_bazel). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC40IiwidXBkYXRlZEluVmVyIjoiMzQuMzAuNCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Nov 23, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.35.0` -> `v0.36.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go</summary> ### [`v0.36.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.35.0...v0.36.0) #### Major new features The Go runfiles library developed by [@​phst](https://togithub.com/phst) at https://github.com/phst/runfiles is now available as `github.com/bazelbuild/rules_go/go/runfiles` (target `@io_bazel_rules_go//go/runfiles`) and is now the official way to look up runfiles from Go. It will be made compatible with Bzlmod in a future release. **Note:** For improved consistency with runfiles libraries in other languages, the `Path` function present in https://github.com/phst/runfiles is called `Rlocation` in rules_go. #### What's Changed - bzlmod: Use register_toolchains by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3290 - Remove unused env_execute by [@​kmicklas](https://togithub.com/kmicklas) in [bazelbuild/rules_go#3276 - Correctly forward InstrumentedFilesInfo from dependencies by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3294 - Parse Go SDK version out of `go version` instead of `VERSION` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3296 - also write test stderr to json (xml) output file by [@​rickystewart](https://togithub.com/rickystewart) in [bazelbuild/rules_go#3300 - Bzlmod: Pin Bazel version in CI by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3301 - Allow to select Go SDK version from declared SDKs by [@​ash2k](https://togithub.com/ash2k) in [bazelbuild/rules_go#3303 - Use top level VERSION file when it exists by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3309 - synchronize when writing to the JSON converter by [@​rickystewart](https://togithub.com/rickystewart) in [bazelbuild/rules_go#3311 - update version manifest URL by [@​benjaminp](https://togithub.com/benjaminp) in [bazelbuild/rules_go#3314 - Symlink "misc" into repository for local_sdk. by [@​adam-azarchs](https://togithub.com/adam-azarchs) in [bazelbuild/rules_go#3313 - Ensure compatibility with incompatible flags close to flipping by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3319 - Add additional bzlmod requirements to allow grpc protobufs to work by [@​shs96c](https://togithub.com/shs96c) in [bazelbuild/rules_go#3320 - bzlmod: Update pinned Bazel version by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3321 - bzlmod: Set up automated BCR releases by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3324 - bzlmod: Add support for gogo proto compiler by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3323 - gopackagesdriver: move non-Go files to OtherFiles (Fixes [#​3326](https://togithub.com/bazelbuild/rules_go/issues/3326)) by [@​michaelarusso](https://togithub.com/michaelarusso) in [bazelbuild/rules_go#3327 - bzlmod: Allow yanked versions in CI by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3329 - feat(pkg-drv): allow setting custom aspect and kinds by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3328 - fix(packages-driver): allow defining additional aspects instead by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3330 - Add support for parsing Go development versions by [@​zakcutner](https://togithub.com/zakcutner) in [bazelbuild/rules_go#3333 - Match GOARCH ppc64 to @​platforms//cpu:ppc as well. by [@​mahiuchun](https://togithub.com/mahiuchun) in [bazelbuild/rules_go#3336 - bzlmod: Update Publish to BCR app config by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3337 - gopackagesdriver: default to NotHandled:true for package queries by [@​ian-h-chamberlain](https://togithub.com/ian-h-chamberlain) in [bazelbuild/rules_go#3338 - fix(packagesdrv): resolve third party go packages by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3332 - runfiles: port phst/runfiles to rules_go by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3205 - Adding gc_linopts to command line flag by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3342 - Move new runfiles library to `//go/runfiles` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3341 - Rename `Path` to `Rlocation` in runfiles library by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3346 - Add 'gc_goopts' flag to command line to allow gc_goopts to propagate by [@​LWarrens](https://togithub.com/LWarrens) in [bazelbuild/rules_go#3340 #### New Contributors - [@​kmicklas](https://togithub.com/kmicklas) made their first contribution in [bazelbuild/rules_go#3276 - [@​adam-azarchs](https://togithub.com/adam-azarchs) made their first contribution in [bazelbuild/rules_go#3313 - [@​shs96c](https://togithub.com/shs96c) made their first contribution in [bazelbuild/rules_go#3320 - [@​michaelarusso](https://togithub.com/michaelarusso) made their first contribution in [bazelbuild/rules_go#3327 - [@​zakcutner](https://togithub.com/zakcutner) made their first contribution in [bazelbuild/rules_go#3333 - [@​mahiuchun](https://togithub.com/mahiuchun) made their first contribution in [bazelbuild/rules_go#3336 - [@​LWarrens](https://togithub.com/LWarrens) made their first contribution in [bazelbuild/rules_go#3340 **Full Changelog**: bazelbuild/rules_go@v0.35.0...v0.36.0 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "ae013bf35bd23234d1dea46b079f1e05ba74ac0321423830119d3e787ec73483", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.36.0/rules_go-v0.36.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.36.0/rules_go-v0.36.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.19.3") </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cgrindel/bazel-starlib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC40IiwidXBkYXRlZEluVmVyIjoiMzQuMzAuNCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kreempuff
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Jan 31, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.35.0` -> `v0.38.1` | --- ### Release Notes <details> <summary>bazelbuild/rules_go</summary> ### [`v0.38.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.38.1) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.38.0...v0.38.1) #### Bug fixes The go_googleapis upgrade in 0.38.0 is too disruptive. It changes the Go import paths of the proto packages, causing build failures in repos trying to upgrade to rules_go 0.38.0. Reverting the go_googleapis to the master of 2022-12-05 ([#​3432](https://togithub.com/bazelbuild/rules_go/issues/3432)) for now to make rules_go upgrades easier. #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "dd926a88a564a9246713a9c00b35315f54cbd46b31a26d5d8fb264c07045f05d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.38.1/rules_go-v0.38.1.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.38.1/rules_go-v0.38.1.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.19.5") **Full Changelog**: bazelbuild/rules_go@v0.38.0...v0.38.1 ### [`v0.38.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.38.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.37.0...v0.38.0) #### Breaking changes Starting this release, rules_go requires Bazel 5.3 and golang/x/tools at least 0.3.0. If you are using [stardoc](https://togithub.com/bazelbuild/stardoc), you also need to upgrade it to 0.5.3 to recognize `RunEnvironmentInfo`, which is used in this release. #### Major new features This is the first release to support Go 1.20. When on this version of Go, it is highly recommended to use Bazel 6 and set `--experimental_output_directory_naming_scheme=diff_against_baseline` to prevent certain unnecessary rebuilds. #### What's Changed - preserve intermediate files if `-work` is specified by [@​motiejus](https://togithub.com/motiejus) in [bazelbuild/rules_go#3389 - Adapt `lcov_coverage_test` to `exec.Command` change by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3392 - explicitly build relative path for Tool command in lcov_coverage_test by [@​matloob](https://togithub.com/matloob) in [bazelbuild/rules_go#3399 - Add support for building with boringcrypto by [@​matloob](https://togithub.com/matloob) in [bazelbuild/rules_go#3398 - Generalize `boringcrypto` to `GOEXPERIMENT` support by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3401 - Replace `cfg = "host"` with `cfg = "exec"` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3404 - always produce .a files at the beginning of a build by [@​matloob](https://togithub.com/matloob) in [bazelbuild/rules_go#3385 - Mark `nogo` targets as `manual` to keep top-level symlinks by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3410 - Refactoring the extld related logic by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3400 - Fix incompatible flags not applied to integration tests by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3415 - chore: remove experimental warning from bzlmod module by [@​alexeagle](https://togithub.com/alexeagle) in [bazelbuild/rules_go#3418 - Add a clarifying error about dependency cycle found for internal tests by [@​yushan26](https://togithub.com/yushan26) in [bazelbuild/rules_go#3422 - Do not use exec paths for rundir by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3414 - Upgrade org_golang_x_tools to 0.5.0 by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3356 - fix: Relative path of embedsrc by [@​bakjos](https://togithub.com/bakjos) in [bazelbuild/rules_go#3407 - Add support for env_inherit by [@​ttpathan](https://togithub.com/ttpathan) in [bazelbuild/rules_go#3256 - Update stardoc to 0.5.3 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3427 - Add `env` attribute to `go_binary` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3428 #### New Contributors - [@​matloob](https://togithub.com/matloob) made their first contribution in [bazelbuild/rules_go#3399 - [@​yushan26](https://togithub.com/yushan26) made their first contribution in [bazelbuild/rules_go#3422 - [@​bakjos](https://togithub.com/bakjos) made their first contribution in [bazelbuild/rules_go#3407 - [@​ttpathan](https://togithub.com/ttpathan) made their first contribution in [bazelbuild/rules_go#3256 **Full Changelog**: bazelbuild/rules_go@v0.37.0...v0.38.0 ### [`v0.37.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.37.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.36.0...v0.37.0) #### Major New Features - Support fetching packages for generated code in the Go Packages Driver #### What's Changed - bzlmod: Add missing `strip_prefix` field to `source.template.json` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3359 - Declare toolchains in a separate repository by [@​jfirebaugh](https://togithub.com/jfirebaugh) in [bazelbuild/rules_go#3348 - Delete legacy actions API by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3173 - go_path: support go:embed of generated files by [@​S-Chan](https://togithub.com/S-Chan) in [bazelbuild/rules_go#3285 - Properly deprecate `bindata`, `go_embed_data`, and `go_embed_data_deps` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3362 - link.bzl: ignore duplicate dep on coverdata by [@​robfig](https://togithub.com/robfig) in [bazelbuild/rules_go#3032 - feat(pkg-drv): add support for generated files by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3354 - Remove unused variables in link action by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3367 - Reduce number of declared files in `emit_stdlib` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3366 - Update docs regarding vendored proto files by [@​garymm](https://togithub.com/garymm) in [bazelbuild/rules_go#3360 - go link: use external linker when in race mode by [@​motiejus](https://togithub.com/motiejus) in [bazelbuild/rules_go#3370 - Adding first example by [@​chrislovecnm](https://togithub.com/chrislovecnm) in [bazelbuild/rules_go#3317 - fix(packagesdriver): bazelFlags should prefix the command by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3371 - chore(gpd): export aspect utils for reusability by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3373 - nogo: Add a \_base key to be a default config for all Analyzers. by [@​DolceTriade](https://togithub.com/DolceTriade) in [bazelbuild/rules_go#3351 - Document that `Rlocation` can return relative paths by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3377 - Fix normalization check for `Rlocation` path by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3378 - fix(gpd): Write large target patterns to file by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3372 - Make Go runfiles library repo mapping aware by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3347 #### New Contributors - [@​jfirebaugh](https://togithub.com/jfirebaugh) made their first contribution in [bazelbuild/rules_go#3348 - [@​S-Chan](https://togithub.com/S-Chan) made their first contribution in [bazelbuild/rules_go#3285 - [@​garymm](https://togithub.com/garymm) made their first contribution in [bazelbuild/rules_go#3360 - [@​motiejus](https://togithub.com/motiejus) made their first contribution in [bazelbuild/rules_go#3370 - [@​chrislovecnm](https://togithub.com/chrislovecnm) made their first contribution in [bazelbuild/rules_go#3317 - [@​DolceTriade](https://togithub.com/DolceTriade) made their first contribution in [bazelbuild/rules_go#3351 **Full Changelog**: bazelbuild/rules_go@v0.36.0...v0.37.0 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "56d8c5a5c91e1af73eca71a6fab2ced959b67c86d12ba37feedb0a2dfea441a6", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.37.0/rules_go-v0.37.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.37.0/rules_go-v0.37.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.19.3") ### [`v0.36.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.35.0...v0.36.0) #### Major new features - The Go runfiles library developed by [@​phst](https://togithub.com/phst) at https://github.com/phst/runfiles is now available as `github.com/bazelbuild/rules_go/go/runfiles` (target `@io_bazel_rules_go//go/runfiles`) and is now the official way to look up runfiles from Go. It will be made compatible with Bzlmod in a future release. **Note:** For improved consistency with runfiles libraries in other languages, the `Path` function present in https://github.com/phst/runfiles is called `Rlocation` in rules_go. - Adding two new command line flags `--@​io_bazel_rules_go//go/config:gc_goopts` and `--@​io_bazel_rules_go//go/config:gc_linkopts` to accept additional compiler and linker flags. #### What's Changed - bzlmod: Use register_toolchains by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3290 - Remove unused env_execute by [@​kmicklas](https://togithub.com/kmicklas) in [bazelbuild/rules_go#3276 - Correctly forward InstrumentedFilesInfo from dependencies by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3294 - Parse Go SDK version out of `go version` instead of `VERSION` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3296 - also write test stderr to json (xml) output file by [@​rickystewart](https://togithub.com/rickystewart) in [bazelbuild/rules_go#3300 - Bzlmod: Pin Bazel version in CI by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3301 - Allow to select Go SDK version from declared SDKs by [@​ash2k](https://togithub.com/ash2k) in [bazelbuild/rules_go#3303 - Use top level VERSION file when it exists by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3309 - synchronize when writing to the JSON converter by [@​rickystewart](https://togithub.com/rickystewart) in [bazelbuild/rules_go#3311 - update version manifest URL by [@​benjaminp](https://togithub.com/benjaminp) in [bazelbuild/rules_go#3314 - Symlink "misc" into repository for local_sdk. by [@​adam-azarchs](https://togithub.com/adam-azarchs) in [bazelbuild/rules_go#3313 - Ensure compatibility with incompatible flags close to flipping by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3319 - Add additional bzlmod requirements to allow grpc protobufs to work by [@​shs96c](https://togithub.com/shs96c) in [bazelbuild/rules_go#3320 - bzlmod: Update pinned Bazel version by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3321 - bzlmod: Set up automated BCR releases by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3324 - bzlmod: Add support for gogo proto compiler by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3323 - gopackagesdriver: move non-Go files to OtherFiles (Fixes [#​3326](https://togithub.com/bazelbuild/rules_go/issues/3326)) by [@​michaelarusso](https://togithub.com/michaelarusso) in [bazelbuild/rules_go#3327 - bzlmod: Allow yanked versions in CI by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3329 - feat(pkg-drv): allow setting custom aspect and kinds by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3328 - fix(packages-driver): allow defining additional aspects instead by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3330 - Add support for parsing Go development versions by [@​zakcutner](https://togithub.com/zakcutner) in [bazelbuild/rules_go#3333 - Match GOARCH ppc64 to @​platforms//cpu:ppc as well. by [@​mahiuchun](https://togithub.com/mahiuchun) in [bazelbuild/rules_go#3336 - bzlmod: Update Publish to BCR app config by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3337 - gopackagesdriver: default to NotHandled:true for package queries by [@​ian-h-chamberlain](https://togithub.com/ian-h-chamberlain) in [bazelbuild/rules_go#3338 - fix(packagesdrv): resolve third party go packages by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3332 - runfiles: port phst/runfiles to rules_go by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3205 - Adding gc_linopts to command line flag by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3342 - Move new runfiles library to `//go/runfiles` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3341 - Rename `Path` to `Rlocation` in runfiles library by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3346 - Add 'gc_goopts' flag to command line to allow gc_goopts to propagate by [@​LWarrens](https://togithub.com/LWarrens) in [bazelbuild/rules_go#3340 #### New Contributors - [@​kmicklas](https://togithub.com/kmicklas) made their first contribution in [bazelbuild/rules_go#3276 - [@​adam-azarchs](https://togithub.com/adam-azarchs) made their first contribution in [bazelbuild/rules_go#3313 - [@​shs96c](https://togithub.com/shs96c) made their first contribution in [bazelbuild/rules_go#3320 - [@​michaelarusso](https://togithub.com/michaelarusso) made their first contribution in [bazelbuild/rules_go#3327 - [@​zakcutner](https://togithub.com/zakcutner) made their first contribution in [bazelbuild/rules_go#3333 - [@​mahiuchun](https://togithub.com/mahiuchun) made their first contribution in [bazelbuild/rules_go#3336 - [@​LWarrens](https://togithub.com/LWarrens) made their first contribution in [bazelbuild/rules_go#3340 **Full Changelog**: bazelbuild/rules_go@v0.35.0...v0.36.0 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "ae013bf35bd23234d1dea46b079f1e05ba74ac0321423830119d3e787ec73483", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.36.0/rules_go-v0.36.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.36.0/rules_go-v0.36.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.19.3") </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTcuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExNy4xIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
In #3328 I made it so defining an aspect would overwrite the default one defined by rules_go. This means the custom aspect would need to duplicate the rules_go code and potentially manually merge any changes we do in rules_go every release.
Talking with @linzhp , he indicated that you can pass more than one aspect to
--aspects, so in this case when additional aspects are defined they will be passed in and can export similar info to the default aspect.