New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare toolchains in a separate repository #3348
Merged
linzhp
merged 8 commits into
bazelbuild:master
from
figma:jfirebaugh/separate-toolchains-repo
Nov 24, 2022
Merged
Declare toolchains in a separate repository #3348
linzhp
merged 8 commits into
bazelbuild:master
from
figma:jfirebaugh/separate-toolchains-repo
Nov 24, 2022
Commits on Nov 14, 2022
-
Declare toolchains in a separate repository
For instance, if the SDK repository is `@go_sdk`, the toolchain rules will be defined in `@go_sdk_toolchains`. This avoids eagerly fetching `@go_sdk`, fixing bazelbuild#3196. One caveat: `:sdk_version_setting` needs to be defined in the same repo as the toolchain rule, e.g. in `@go_sdk_toolchains`. I tried `target_settings = "@go_sdk//:sdk_version_setting"`, but that causes `@go_sdk` to be eagerly fetched again. This means that `@go_sdk_toolchains` needs to know the SDK version. There are two possibilities: * The user specifies the version up front, for instance via `go_register_toolchains(version = ...)`. In that case, `@go_sdk_toolchains` uses this version. * The user does not specify the version up front. `go_wrap_sdk`, `go_download_sdk`, and `go_local_sdk` do not require a `version` attribute. In this case, we have no choice but to inspect the SDK itself to obtain the version, forcing an eager load. However, we can at least add an optional `version` attribute to these rules, so that users can avoid the eager fetch if they wish. In all cases, when a `version` attribute is provided by the user, the implementation (lazily) validates that it matches the actual SDK version.
Configuration menu - View commit details
-
Copy full SHA for 59a20d2 - Browse repository at this point
Copy the full SHA 59a20d2View commit details
Commits on Nov 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1823034 - Browse repository at this point
Copy the full SHA 1823034View commit details -
Configuration menu - View commit details
-
Copy full SHA for cce840d - Browse repository at this point
Copy the full SHA cce840dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdfc7d0 - Browse repository at this point
Copy the full SHA bdfc7d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64f9a0a - Browse repository at this point
Copy the full SHA 64f9a0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ca6ddb - Browse repository at this point
Copy the full SHA 8ca6ddbView commit details
Commits on Nov 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bca8a4b - Browse repository at this point
Copy the full SHA bca8a4bView commit details
Commits on Nov 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5fb202a - Browse repository at this point
Copy the full SHA 5fb202aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.