Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare toolchains in a separate repository #3348

Merged
merged 8 commits into from Nov 24, 2022
Merged

Declare toolchains in a separate repository #3348

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
59a20d2
Declare toolchains in a separate repository
jfirebaugh Nov 9, 2022
1823034
Fix failing test
jfirebaugh Nov 15, 2022
cce840d
_version_constants -> _define_version_constants
jfirebaugh Nov 15, 2022
bdfc7d0
Maintain backward compatibility for declare_toolchains
jfirebaugh Nov 15, 2022
64f9a0a
Keep declare_{go,bazel}_toolchains private
jfirebaugh Nov 15, 2022
8ca6ddb
Fix failing test
jfirebaugh Nov 15, 2022
bca8a4b
Try removing go_default_sdk
jfirebaugh Nov 16, 2022
5fb202a
Refine documentation
jfirebaugh Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ use_repo(

go_sdk = use_extension("//go:extensions.bzl", "go_sdk")
go_sdk.download(name = "go_default_sdk", version = "1.18.3")
use_repo(go_sdk, "go_default_sdk")
use_repo(go_sdk, "go_default_sdk", "go_default_sdk_toolchains")
fmeum marked this conversation as resolved.
Show resolved Hide resolved
register_toolchains("@go_default_sdk_toolchains//:all")

bazel_dep(name = "gazelle", version = "0.27.0")
Expand Down