nogo: Create a go_register_nogo wrapper for WORKSPACE users. #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Jan 27, 2024
fmeum
reviewed
Jan 27, 2024
fmeum
reviewed
Jan 27, 2024
|
Tests should be fixed...at least they don't fail locally. |
|
@fmeum I'm not sure the includes/excludes support works on Bazel 5.4.0. I suspect this was never tested because it was only used by bzlmod until now. Is it important for the includes/excludes support to work for 5.4.0? Is there a way we can ignore this test on older versions of bazel? |
|
Sure, just exclude it here: rules_go/.bazelci/presubmit.yml Line 29 in 30099a6 |
|
Ok! Now all tests pass! |
Currently, workspace users register nogo targets by abusing the go_register_toolchain() function, which calls go_register_nogo(). Instead, we should expose go_register_nogo to workspace users directly. This will allow workspace users and bzlmod users to use the same underlying code because go_register_nogo allows users to specify includes and excludes which you currently can't do with WORKSPACE. Add a test to verify this functionality works in WORKSPACE too.
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Feb 10, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.45.1` -> `v0.46.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.46.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.46.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.45.1...v0.46.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "80a98277ad1311dacd837f9b16db62887702e9f1d1c4c9f796d0121a46c8e184", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.46.0/rules_go-v0.46.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.46.0/rules_go-v0.46.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.0") #### What's Changed - Support custom `GOARM` architecture levels via platform constraints by [@​LINKIWI](https://togithub.com/LINKIWI) in [bazelbuild/rules_go#3837 - Emit nogo facts into a separate archive by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3789 - go_test: ensure external source compilation has data by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3848 - Fix invocation of assembler for go1.22 by [@​jquirke](https://togithub.com/jquirke) in [bazelbuild/rules_go#3756 - nogo: Create a go_register_nogo wrapper for WORKSPACE users. by [@​DolceTriade](https://togithub.com/DolceTriade) in [bazelbuild/rules_go#3842 - prepare minor release 0.46 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3854 #### New Contributors - [@​LINKIWI](https://togithub.com/LINKIWI) made their first contribution in [bazelbuild/rules_go#3837 - [@​jquirke](https://togithub.com/jquirke) made their first contribution in [bazelbuild/rules_go#3756 **Full Changelog**: bazelbuild/rules_go@v0.45.1...v0.46.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Feb 10, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.45.1` -> `v0.46.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.46.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.46.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.45.1...v0.46.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "80a98277ad1311dacd837f9b16db62887702e9f1d1c4c9f796d0121a46c8e184", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.46.0/rules_go-v0.46.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.46.0/rules_go-v0.46.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.0") #### What's Changed - Support custom `GOARM` architecture levels via platform constraints by [@​LINKIWI](https://togithub.com/LINKIWI) in [bazelbuild/rules_go#3837 - Emit nogo facts into a separate archive by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3789 - go_test: ensure external source compilation has data by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3848 - Fix invocation of assembler for go1.22 by [@​jquirke](https://togithub.com/jquirke) in [bazelbuild/rules_go#3756 - nogo: Create a go_register_nogo wrapper for WORKSPACE users. by [@​DolceTriade](https://togithub.com/DolceTriade) in [bazelbuild/rules_go#3842 - prepare minor release 0.46 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3854 #### New Contributors - [@​LINKIWI](https://togithub.com/LINKIWI) made their first contribution in [bazelbuild/rules_go#3837 - [@​jquirke](https://togithub.com/jquirke) made their first contribution in [bazelbuild/rules_go#3756 **Full Changelog**: bazelbuild/rules_go@v0.45.1...v0.46.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Feb 10, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.45.1` -> `v0.46.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.46.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.46.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.45.1...v0.46.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "80a98277ad1311dacd837f9b16db62887702e9f1d1c4c9f796d0121a46c8e184", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.46.0/rules_go-v0.46.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.46.0/rules_go-v0.46.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.0") #### What's Changed - Support custom `GOARM` architecture levels via platform constraints by [@​LINKIWI](https://togithub.com/LINKIWI) in [bazelbuild/rules_go#3837 - Emit nogo facts into a separate archive by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3789 - go_test: ensure external source compilation has data by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3848 - Fix invocation of assembler for go1.22 by [@​jquirke](https://togithub.com/jquirke) in [bazelbuild/rules_go#3756 - nogo: Create a go_register_nogo wrapper for WORKSPACE users. by [@​DolceTriade](https://togithub.com/DolceTriade) in [bazelbuild/rules_go#3842 - prepare minor release 0.46 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3854 #### New Contributors - [@​LINKIWI](https://togithub.com/LINKIWI) made their first contribution in [bazelbuild/rules_go#3837 - [@​jquirke](https://togithub.com/jquirke) made their first contribution in [bazelbuild/rules_go#3756 **Full Changelog**: bazelbuild/rules_go@v0.45.1...v0.46.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Currently, workspace users register nogo targets by abusing the go_register_toolchain() function, which calls go_register_nogo(). Instead, we should expose go_register_nogo to workspace users directly. This will allow workspace users and bzlmod users to use the same underlying code because go_register_nogo allows users to specify includes and excludes which you currently can't do with WORKSPACE.
Add a test to verify this functionality works in WORKSPACE too.
Which issues(s) does this PR fix?
Fixes #3838