Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass correct (non "main") importpath to nogo for main package #3863

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Strum355
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

In #2135, the importmap passed to emit_compilepkg is "main" if is_main is set (typically via the go_binary rule). This value also gets sent to nogo, which is the wrong value to send for a main package:

Minimal reproduction using x/tools/go/analysis/singlechecker
// go.mod
module sampletext

go 1.21.6

require golang.org/x/tools v0.18.0
require golang.org/x/mod v0.15.0 // indirect
// main.go
package main

import (
	"fmt"

	"golang.org/x/tools/go/analysis"
	"golang.org/x/tools/go/analysis/singlechecker"
)

var Analyzer = &analysis.Analyzer{
	Name: "test", 
    Doc:  "test", 
    Run: func(p *analysis.Pass) (interface{}, error) {
		fmt.Println(p.Pkg.Path())
		return nil, nil
	},
}

func main() { singlechecker.Main(Analyzer) }
$ go run main.go .
sampletext

Which issues(s) does this PR fix?

No issue opened. Should I open one alongside this PR?

Other notes for review

My original note of the issue: sourcegraph/sourcegraph#54836 (comment)
PR where I introduced a first-iteration patch: https://github.com/sourcegraph/sourcegraph/pull/58971/files
I'd been meaning to open a PR for this here for some time, but only found the time to do so now. Apologies!

@Strum355
Copy link
Contributor Author

Failing tests appear to be due to grailbio/bazel-toolchain being move to bazel-contrib/toolchains_llvm

https://bazelbuild.slack.com/archives/CA31HN1T3/p1707845173596379

Copy link
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will merge after fixing the pipeline.

@fmeum fmeum enabled auto-merge (squash) February 14, 2024 08:17
@fmeum fmeum merged commit f0e46ec into bazelbuild:master Feb 14, 2024
2 checks passed
Strum355 added a commit to sourcegraph/sourcegraph that referenced this pull request Apr 8, 2024
Updating the patch based on bazelbuild/rules_go#3863 having been merged, the old patch doesn't apply cleanly to 0.46.0 anyway.

## Test plan

CI
cgrindel-self-hosted-renovate bot added a commit to cgrindel/bazel-starlib that referenced this pull request Apr 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.46.0` -> `v0.47.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.47.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.22.2")

#### What's Changed

- Add Bazel version matrix to BCR `presubmit.yml` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3861
- Update toolchains_llvm URL and hash by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3864
- pass correct (non `"main"`) importpath to nogo for `main` package by
[@&#8203;Strum355](https://togithub.com/Strum355) in
[bazelbuild/rules_go#3863
- Make exec cfg check for `//go` stricter by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3867
- Fixes the Bazel CI error by
[@&#8203;sgowroji](https://togithub.com/sgowroji) in
[bazelbuild/rules_go#3869
- \[go_library] add .x file to declared output files in DefaultInfo by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/rules_go#3866
- Remove Latin-1 workaround on Bazel 6.4.0+ by
[@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) in
[bazelbuild/rules_go#3872
- fix sdk download for common execution platforms by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[bazelbuild/rules_go#3874
- Bump Go version to 1.21.8 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3880
- Update README.rst to point to correct GH release tags by
[@&#8203;dcarney](https://togithub.com/dcarney) in
[bazelbuild/rules_go#3881
- Update bzlmod.md fix typo by
[@&#8203;mmrath](https://togithub.com/mmrath) in
[bazelbuild/rules_go#3882
- Cleanup temp dirs in GoToolchainBinaryBuild by
[@&#8203;hauserx](https://togithub.com/hauserx) in
[bazelbuild/rules_go#3885
- gopackagesdriver: move and simplify test by
[@&#8203;jayconrod](https://togithub.com/jayconrod) in
[bazelbuild/rules_go#3856
- Support Go version schema change since 1.21 by
[@&#8203;baizhenyu](https://togithub.com/baizhenyu) in
[bazelbuild/rules_go#3891
- gopackagesdriver: fix version check with Bazel development versions by
[@&#8203;jayconrod](https://togithub.com/jayconrod) in
[bazelbuild/rules_go#3893
- Revert "improving logging for subcommand failure
([#&#8203;3824](https://togithub.com/bazelbuild/rules_go/issues/3824))"
by [@&#8203;linzhp](https://togithub.com/linzhp) in
[bazelbuild/rules_go#3892
- Replace instances of to_json() method with json.encode(..) by
[@&#8203;c-mita](https://togithub.com/c-mita) in
[bazelbuild/rules_go#3896
- add nogo parsing support for nogo explanations by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/rules_go#3899
- \[nogo] match regexp againts relative paths by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[bazelbuild/rules_go#3898
- Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3903
- Add //go/private:polyfill_bazel_features.bzl to sources. by
[@&#8203;spags-lacework](https://togithub.com/spags-lacework) in
[bazelbuild/rules_go#3908
- Reformat with buildifier by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3910
- GoLink action. Use -extar <ar path> if cc_toolchain provides ar path
by [@&#8203;OparinE](https://togithub.com/OparinE) in
[bazelbuild/rules_go#3916
- Mark `go_sdk` extension as `reproducible` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3911
- Don't ignore the return value of runfiles.merge_all() by
[@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[bazelbuild/rules_go#3918
- Use Gazelle's `go_env` in `@rules_go//go` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3909
- Setting test.timeout according to TEST_TIMEOUT by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[bazelbuild/rules_go#3920
- prepare rules_go v 0.47 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/rules_go#3923

#### New Contributors

- [@&#8203;Strum355](https://togithub.com/Strum355) made their first
contribution in
[bazelbuild/rules_go#3863
- [@&#8203;sgowroji](https://togithub.com/sgowroji) made their first
contribution in
[bazelbuild/rules_go#3869
- [@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) made their
first contribution in
[bazelbuild/rules_go#3872
- [@&#8203;scaiper](https://togithub.com/scaiper) made their first
contribution in
[bazelbuild/rules_go#3874
- [@&#8203;dcarney](https://togithub.com/dcarney) made their first
contribution in
[bazelbuild/rules_go#3881
- [@&#8203;mmrath](https://togithub.com/mmrath) made their first
contribution in
[bazelbuild/rules_go#3882
- [@&#8203;hauserx](https://togithub.com/hauserx) made their first
contribution in
[bazelbuild/rules_go#3885
- [@&#8203;baizhenyu](https://togithub.com/baizhenyu) made their first
contribution in
[bazelbuild/rules_go#3891
- [@&#8203;c-mita](https://togithub.com/c-mita) made their first
contribution in
[bazelbuild/rules_go#3896
- [@&#8203;spags-lacework](https://togithub.com/spags-lacework) made
their first contribution in
[bazelbuild/rules_go#3908
- [@&#8203;OparinE](https://togithub.com/OparinE) made their first
contribution in
[bazelbuild/rules_go#3916

**Full Changelog**:
bazelbuild/rules_go@v0.46.0...v0.47.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot added a commit to kreempuff/rules_unreal_engine that referenced this pull request Apr 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.46.0` -> `v0.47.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.47.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.22.2")

#### What's Changed

- Add Bazel version matrix to BCR `presubmit.yml` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3861
- Update toolchains_llvm URL and hash by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3864
- pass correct (non `"main"`) importpath to nogo for `main` package by
[@&#8203;Strum355](https://togithub.com/Strum355) in
[bazelbuild/rules_go#3863
- Make exec cfg check for `//go` stricter by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3867
- Fixes the Bazel CI error by
[@&#8203;sgowroji](https://togithub.com/sgowroji) in
[bazelbuild/rules_go#3869
- \[go_library] add .x file to declared output files in DefaultInfo by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/rules_go#3866
- Remove Latin-1 workaround on Bazel 6.4.0+ by
[@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) in
[bazelbuild/rules_go#3872
- fix sdk download for common execution platforms by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[bazelbuild/rules_go#3874
- Bump Go version to 1.21.8 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3880
- Update README.rst to point to correct GH release tags by
[@&#8203;dcarney](https://togithub.com/dcarney) in
[bazelbuild/rules_go#3881
- Update bzlmod.md fix typo by
[@&#8203;mmrath](https://togithub.com/mmrath) in
[bazelbuild/rules_go#3882
- Cleanup temp dirs in GoToolchainBinaryBuild by
[@&#8203;hauserx](https://togithub.com/hauserx) in
[bazelbuild/rules_go#3885
- gopackagesdriver: move and simplify test by
[@&#8203;jayconrod](https://togithub.com/jayconrod) in
[bazelbuild/rules_go#3856
- Support Go version schema change since 1.21 by
[@&#8203;baizhenyu](https://togithub.com/baizhenyu) in
[bazelbuild/rules_go#3891
- gopackagesdriver: fix version check with Bazel development versions by
[@&#8203;jayconrod](https://togithub.com/jayconrod) in
[bazelbuild/rules_go#3893
- Revert "improving logging for subcommand failure
([#&#8203;3824](https://togithub.com/bazelbuild/rules_go/issues/3824))"
by [@&#8203;linzhp](https://togithub.com/linzhp) in
[bazelbuild/rules_go#3892
- Replace instances of to_json() method with json.encode(..) by
[@&#8203;c-mita](https://togithub.com/c-mita) in
[bazelbuild/rules_go#3896
- add nogo parsing support for nogo explanations by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/rules_go#3899
- \[nogo] match regexp againts relative paths by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[bazelbuild/rules_go#3898
- Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3903
- Add //go/private:polyfill_bazel_features.bzl to sources. by
[@&#8203;spags-lacework](https://togithub.com/spags-lacework) in
[bazelbuild/rules_go#3908
- Reformat with buildifier by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3910
- GoLink action. Use -extar <ar path> if cc_toolchain provides ar path
by [@&#8203;OparinE](https://togithub.com/OparinE) in
[bazelbuild/rules_go#3916
- Mark `go_sdk` extension as `reproducible` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3911
- Don't ignore the return value of runfiles.merge_all() by
[@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[bazelbuild/rules_go#3918
- Use Gazelle's `go_env` in `@rules_go//go` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3909
- Setting test.timeout according to TEST_TIMEOUT by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[bazelbuild/rules_go#3920
- prepare rules_go v 0.47 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/rules_go#3923

#### New Contributors

- [@&#8203;Strum355](https://togithub.com/Strum355) made their first
contribution in
[bazelbuild/rules_go#3863
- [@&#8203;sgowroji](https://togithub.com/sgowroji) made their first
contribution in
[bazelbuild/rules_go#3869
- [@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) made their
first contribution in
[bazelbuild/rules_go#3872
- [@&#8203;scaiper](https://togithub.com/scaiper) made their first
contribution in
[bazelbuild/rules_go#3874
- [@&#8203;dcarney](https://togithub.com/dcarney) made their first
contribution in
[bazelbuild/rules_go#3881
- [@&#8203;mmrath](https://togithub.com/mmrath) made their first
contribution in
[bazelbuild/rules_go#3882
- [@&#8203;hauserx](https://togithub.com/hauserx) made their first
contribution in
[bazelbuild/rules_go#3885
- [@&#8203;baizhenyu](https://togithub.com/baizhenyu) made their first
contribution in
[bazelbuild/rules_go#3891
- [@&#8203;c-mita](https://togithub.com/c-mita) made their first
contribution in
[bazelbuild/rules_go#3896
- [@&#8203;spags-lacework](https://togithub.com/spags-lacework) made
their first contribution in
[bazelbuild/rules_go#3908
- [@&#8203;OparinE](https://togithub.com/OparinE) made their first
contribution in
[bazelbuild/rules_go#3916

**Full Changelog**:
bazelbuild/rules_go@v0.46.0...v0.47.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Apr 24, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.46.0` -> `v0.47.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.47.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.22.2")

#### What's Changed

- Add Bazel version matrix to BCR `presubmit.yml` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3861
- Update toolchains_llvm URL and hash by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3864
- pass correct (non `"main"`) importpath to nogo for `main` package by
[@&#8203;Strum355](https://togithub.com/Strum355) in
[bazelbuild/rules_go#3863
- Make exec cfg check for `//go` stricter by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3867
- Fixes the Bazel CI error by
[@&#8203;sgowroji](https://togithub.com/sgowroji) in
[bazelbuild/rules_go#3869
- \[go_library] add .x file to declared output files in DefaultInfo by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/rules_go#3866
- Remove Latin-1 workaround on Bazel 6.4.0+ by
[@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) in
[bazelbuild/rules_go#3872
- fix sdk download for common execution platforms by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[bazelbuild/rules_go#3874
- Bump Go version to 1.21.8 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3880
- Update README.rst to point to correct GH release tags by
[@&#8203;dcarney](https://togithub.com/dcarney) in
[bazelbuild/rules_go#3881
- Update bzlmod.md fix typo by
[@&#8203;mmrath](https://togithub.com/mmrath) in
[bazelbuild/rules_go#3882
- Cleanup temp dirs in GoToolchainBinaryBuild by
[@&#8203;hauserx](https://togithub.com/hauserx) in
[bazelbuild/rules_go#3885
- gopackagesdriver: move and simplify test by
[@&#8203;jayconrod](https://togithub.com/jayconrod) in
[bazelbuild/rules_go#3856
- Support Go version schema change since 1.21 by
[@&#8203;baizhenyu](https://togithub.com/baizhenyu) in
[bazelbuild/rules_go#3891
- gopackagesdriver: fix version check with Bazel development versions by
[@&#8203;jayconrod](https://togithub.com/jayconrod) in
[bazelbuild/rules_go#3893
- Revert "improving logging for subcommand failure
([#&#8203;3824](https://togithub.com/bazelbuild/rules_go/issues/3824))"
by [@&#8203;linzhp](https://togithub.com/linzhp) in
[bazelbuild/rules_go#3892
- Replace instances of to_json() method with json.encode(..) by
[@&#8203;c-mita](https://togithub.com/c-mita) in
[bazelbuild/rules_go#3896
- add nogo parsing support for nogo explanations by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/rules_go#3899
- \[nogo] match regexp againts relative paths by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[bazelbuild/rules_go#3898
- Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3903
- Add //go/private:polyfill_bazel_features.bzl to sources. by
[@&#8203;spags-lacework](https://togithub.com/spags-lacework) in
[bazelbuild/rules_go#3908
- Reformat with buildifier by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3910
- GoLink action. Use -extar <ar path> if cc_toolchain provides ar path
by [@&#8203;OparinE](https://togithub.com/OparinE) in
[bazelbuild/rules_go#3916
- Mark `go_sdk` extension as `reproducible` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3911
- Don't ignore the return value of runfiles.merge_all() by
[@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[bazelbuild/rules_go#3918
- Use Gazelle's `go_env` in `@rules_go//go` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3909
- Setting test.timeout according to TEST_TIMEOUT by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[bazelbuild/rules_go#3920
- prepare rules_go v 0.47 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/rules_go#3923

#### New Contributors

- [@&#8203;Strum355](https://togithub.com/Strum355) made their first
contribution in
[bazelbuild/rules_go#3863
- [@&#8203;sgowroji](https://togithub.com/sgowroji) made their first
contribution in
[bazelbuild/rules_go#3869
- [@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) made their
first contribution in
[bazelbuild/rules_go#3872
- [@&#8203;scaiper](https://togithub.com/scaiper) made their first
contribution in
[bazelbuild/rules_go#3874
- [@&#8203;dcarney](https://togithub.com/dcarney) made their first
contribution in
[bazelbuild/rules_go#3881
- [@&#8203;mmrath](https://togithub.com/mmrath) made their first
contribution in
[bazelbuild/rules_go#3882
- [@&#8203;hauserx](https://togithub.com/hauserx) made their first
contribution in
[bazelbuild/rules_go#3885
- [@&#8203;baizhenyu](https://togithub.com/baizhenyu) made their first
contribution in
[bazelbuild/rules_go#3891
- [@&#8203;c-mita](https://togithub.com/c-mita) made their first
contribution in
[bazelbuild/rules_go#3896
- [@&#8203;spags-lacework](https://togithub.com/spags-lacework) made
their first contribution in
[bazelbuild/rules_go#3908
- [@&#8203;OparinE](https://togithub.com/OparinE) made their first
contribution in
[bazelbuild/rules_go#3916

**Full Changelog**:
bazelbuild/rules_go@v0.46.0...v0.47.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
fmeum pushed a commit to bazel-contrib/toolchains_llvm that referenced this pull request May 2, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.46.0` -> `v0.47.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.47.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.22.2")

#### What's Changed

- Add Bazel version matrix to BCR `presubmit.yml` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3861
- Update toolchains_llvm URL and hash by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3864
- pass correct (non `"main"`) importpath to nogo for `main` package by
[@&#8203;Strum355](https://togithub.com/Strum355) in
[bazelbuild/rules_go#3863
- Make exec cfg check for `//go` stricter by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3867
- Fixes the Bazel CI error by
[@&#8203;sgowroji](https://togithub.com/sgowroji) in
[bazelbuild/rules_go#3869
- \[go_library] add .x file to declared output files in DefaultInfo by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/rules_go#3866
- Remove Latin-1 workaround on Bazel 6.4.0+ by
[@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) in
[bazelbuild/rules_go#3872
- fix sdk download for common execution platforms by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[bazelbuild/rules_go#3874
- Bump Go version to 1.21.8 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3880
- Update README.rst to point to correct GH release tags by
[@&#8203;dcarney](https://togithub.com/dcarney) in
[bazelbuild/rules_go#3881
- Update bzlmod.md fix typo by
[@&#8203;mmrath](https://togithub.com/mmrath) in
[bazelbuild/rules_go#3882
- Cleanup temp dirs in GoToolchainBinaryBuild by
[@&#8203;hauserx](https://togithub.com/hauserx) in
[bazelbuild/rules_go#3885
- gopackagesdriver: move and simplify test by
[@&#8203;jayconrod](https://togithub.com/jayconrod) in
[bazelbuild/rules_go#3856
- Support Go version schema change since 1.21 by
[@&#8203;baizhenyu](https://togithub.com/baizhenyu) in
[bazelbuild/rules_go#3891
- gopackagesdriver: fix version check with Bazel development versions by
[@&#8203;jayconrod](https://togithub.com/jayconrod) in
[bazelbuild/rules_go#3893
- Revert "improving logging for subcommand failure
([#&#8203;3824](https://togithub.com/bazelbuild/rules_go/issues/3824))"
by [@&#8203;linzhp](https://togithub.com/linzhp) in
[bazelbuild/rules_go#3892
- Replace instances of to_json() method with json.encode(..) by
[@&#8203;c-mita](https://togithub.com/c-mita) in
[bazelbuild/rules_go#3896
- add nogo parsing support for nogo explanations by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/rules_go#3899
- \[nogo] match regexp againts relative paths by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[bazelbuild/rules_go#3898
- Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3903
- Add //go/private:polyfill_bazel_features.bzl to sources. by
[@&#8203;spags-lacework](https://togithub.com/spags-lacework) in
[bazelbuild/rules_go#3908
- Reformat with buildifier by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3910
- GoLink action. Use -extar <ar path> if cc_toolchain provides ar path
by [@&#8203;OparinE](https://togithub.com/OparinE) in
[bazelbuild/rules_go#3916
- Mark `go_sdk` extension as `reproducible` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3911
- Don't ignore the return value of runfiles.merge_all() by
[@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[bazelbuild/rules_go#3918
- Use Gazelle's `go_env` in `@rules_go//go` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/rules_go#3909
- Setting test.timeout according to TEST_TIMEOUT by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[bazelbuild/rules_go#3920
- prepare rules_go v 0.47 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/rules_go#3923

#### New Contributors

- [@&#8203;Strum355](https://togithub.com/Strum355) made their first
contribution in
[bazelbuild/rules_go#3863
- [@&#8203;sgowroji](https://togithub.com/sgowroji) made their first
contribution in
[bazelbuild/rules_go#3869
- [@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) made their
first contribution in
[bazelbuild/rules_go#3872
- [@&#8203;scaiper](https://togithub.com/scaiper) made their first
contribution in
[bazelbuild/rules_go#3874
- [@&#8203;dcarney](https://togithub.com/dcarney) made their first
contribution in
[bazelbuild/rules_go#3881
- [@&#8203;mmrath](https://togithub.com/mmrath) made their first
contribution in
[bazelbuild/rules_go#3882
- [@&#8203;hauserx](https://togithub.com/hauserx) made their first
contribution in
[bazelbuild/rules_go#3885
- [@&#8203;baizhenyu](https://togithub.com/baizhenyu) made their first
contribution in
[bazelbuild/rules_go#3891
- [@&#8203;c-mita](https://togithub.com/c-mita) made their first
contribution in
[bazelbuild/rules_go#3896
- [@&#8203;spags-lacework](https://togithub.com/spags-lacework) made
their first contribution in
[bazelbuild/rules_go#3908
- [@&#8203;OparinE](https://togithub.com/OparinE) made their first
contribution in
[bazelbuild/rules_go#3916

**Full Changelog**:
bazelbuild/rules_go@v0.46.0...v0.47.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants