Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support orbit package types #117

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Support orbit package types #117

merged 2 commits into from
Apr 17, 2019

Conversation

mandrean
Copy link
Contributor

Fixes #116.

@mandrean mandrean mentioned this pull request Apr 17, 2019
Closed
@dkelmer
Copy link
Contributor

dkelmer commented Apr 17, 2019

Thanks for the PR!
Can you add a regression test for this case? Do this by adding the artifact to this WORKSPACE file and this BUILD file

@mandrean
Copy link
Contributor Author

@dkelmer Consider it done!

@dkelmer
Copy link
Contributor

dkelmer commented Apr 17, 2019

Thanks you :)

@dkelmer dkelmer merged commit 3fb3c1a into bazelbuild:master Apr 17, 2019
@mandrean mandrean deleted the patch-1 branch April 17, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkelmer dkelmer dkelmer approved these changes

@jin jin Awaiting requested review from jin jin is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "orbit" package types
3 participants
@mandrean @dkelmer @googlebot