Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "orbit" package types #116

Closed
mandrean opened this issue Apr 17, 2019 · 2 comments · Fixed by #117
Closed

Support "orbit" package types #116

mandrean opened this issue Apr 17, 2019 · 2 comments · Fixed by #117

Comments

@mandrean
Copy link
Contributor

When using rules_jvm_external on a project pulling in an old version of Dropwizard ("io.dropwizard:dropwizard-core:0.7.1",), Bazel fails miserably because one of Dropwizard's declared dependencies in the POM being of package type orbit:

org.eclipse.jetty.orbit:javax.servlet:3.0.0.v201112011016

<groupId>org.eclipse.jetty.orbit</groupId>
<artifactId>javax.servlet</artifactId>
<version>3.0.0.v201112011016</version>
<name>Jetty Orbit :: Servlet API</name>
<description>
This artifact originates from the Orbit Project at Eclipse, it is an osgi bundle and is signed as well.
</description>
<packaging>orbit</packaging>

Fetching/resolving it with the coursier CLI works fine though. Should be an easy fix.

mandrean added a commit to mandrean/rules_jvm_external that referenced this issue Apr 17, 2019
@mandrean
Copy link
Contributor Author

PR: #117

@jin
Copy link
Member

jin commented Apr 17, 2019

Interesting - the error message for this gets printed 17 times when I add it to an Android project's WORKSPACE file.

Parsed artifact data: {"coord": "org.eclipse.jetty.orbit:javax.servlet:3.0.0.v201112011016", "file": None, "dependencies": []} and referenced by '//java/com/google/android/apps/authenticator:authenticator_lib'
ERROR: Analysis of target '//java/com/google/android/apps/authenticator:authenticator' failed; build aborted: no such package '@maven//': Traceback (most recent call last):
	File "/private/var/tmp/_bazel_jin/01df7c89101fa69de4358628ee7e3155/external/rules_jvm_external/coursier.bzl", line 536
		generate_imports(repository_ctx = repository_ctx, d..., <2 more arguments>)
	File "/private/var/tmp/_bazel_jin/01df7c89101fa69de4358628ee7e3155/external/rules_jvm_external/coursier.bzl", line 335, in generate_imports
		fail(error_message)

The artifact for org.eclipse.jetty.orbit:javax.servlet:3.0.0.v201112011016 was not downloaded. Perhaps its packaging type is
not one of: jar,aar,bundle,eclipse-plugin?

It is also possible that the packaging type of org.eclipse.jetty.orbit:javax.servlet:3.0.0.v201112011016 is specified
incorrectly in the POM file of an artifact that depends on it. For example,
org.eclipse.jetty.orbit:javax.servlet:3.0.0.v201112011016 may be an AAR, but the dependent's POM file specified its `<type>`
value to be a JAR.

The artifact(s) depending on org.eclipse.jetty.orbit:javax.servlet:3.0.0.v201112011016 are:



and their POM files are located at:



---

dkelmer pushed a commit that referenced this issue Apr 17, 2019
* Support orbit package types

Fixes #116.

* Add orbit regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants