Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coursier cache path logic for https://github.com/bazelbuild/rules_jvm_external/issues/417 #419

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

cheister
Copy link
Collaborator

@cheister cheister commented Jun 4, 2020

Update how the default coursier cache path is calculated based on the existence of a $HOME/.coursier directory.

Based on https://github.com/coursier/coursier/blob/f48c1c6b01ac5b720e66e06cf93587b21d030e8c/modules/paths/src/main/java/coursier/paths/CoursierPaths.java#L60

From #417

Additional information: https://get-coursier.io/docs/cache.html#compatibility-with-former-versions

Copy link
Member

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, LGTM - would like to wait for @joprice's verification.

@jin
Copy link
Member

jin commented Jun 9, 2020

I added a link to https://get-coursier.io/docs/cache.html#compatibility-with-former-versions in the PR description.

Merging!

@jin jin merged commit f0a1fc8 into bazelbuild:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants