Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tags in java_export rule #444

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

gibfahn
Copy link
Contributor

@gibfahn gibfahn commented Aug 12, 2020

Using "Tags" attribute on java_export() rule generates:

java_library(...)
got multiple values for parameter 'tags' via java_export rules

Using "Tags" attribute on java_export() rule generates java_library(...)
got multiple values for parameter 'tags' via java_export rules.
@gibfahn
Copy link
Contributor Author

gibfahn commented Aug 12, 2020

cc/ @shs96c

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this.

@shs96c shs96c merged commit aed0eb3 into bazelbuild:master Aug 12, 2020
@gibfahn gibfahn deleted the tag_handling branch August 12, 2020 20:12
@jin jin mentioned this pull request Jan 6, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants