Add @maven//:outdated to check for updated versions of artifacts #465

cheister · 2020-10-12T06:51:04Z

This adds an outdated action to a maven_install repository so you can run

bazel run @maven//:outdated

to check for updated versions of artifacts. e.g.

Checking for updates of 23 artifacts against the following repositories:
	https://repo1.maven.org/maven2
	https://digitalassetsdk.bintray.com/DigitalAssetSDK
	https://maven.google.com
	https://packages.confluent.io/maven/

org.pantsbuild:jarjar [1.6.6 -> 1.7.2]
junit:junit [4.12 -> 4.13.1]
org.jetbrains.kotlin:kotlin-test [1.3.21 -> 1.4.10]
com.digitalasset:damlc [100.12.1 -> 100.13.45]
com.squareup:javapoet [1.11.1 -> 1.13.0]

cheister · 2020-10-12T06:52:37Z

private/outdated.sh

+
+set -euo pipefail
+
+if [ -f "private/tools/prebuilt/outdated_deploy.jar" ]; then


I'm not sure if there is a better way to check if the action is running inside the rules_jvm_external repo or outside of it.

There's an open issue that coursier should run with the java runtime configured for the build (#445) I'd suggest relying on that, and then you could use $(location) to expand the location of the deploy jar in a rule or macro that writes this file.

As far as I can tell #445 is still an open issue because JAVABASE is not exposed to repository rules. If we fix JAVABASE for the java that coursier uses we should fix it here also but I don't currently see a straightforward fix otherwise.

cheister · 2020-10-12T06:54:03Z

private/tools/java/rules/jvm/external/maven/Outdated.java

+        releaseVersion = getReleaseVersion(repository, groupId, artifactId);
+        if (releaseVersion != null) {
+          verboseLog(String.format("Found version [%s] for %s:%s in %s", releaseVersion, groupId, artifactId, repository));
+          // Should we search all repositories in the list for latest version instead of just the first


Using the first one found has been working for me but may not find the truly latest version of an artifact in the list of repositories.

I think this is reasonable, but to reduce potential confusion, I think the repository where this lookup succeeded should be printed regardless of RJE_VERBOSE.

Do you mind if we leave this only in verbose mode? Mainly because it keeps the output clean and I'm not sure I know of any other outdated tool that tells you where it found the update by default.

private/outdated.sh

shs96c

The logic in Outdated.java looks good to me.

shs96c · 2020-10-27T11:25:08Z

private/outdated.sh

+
+set -euo pipefail
+
+if [ -f "private/tools/prebuilt/outdated_deploy.jar" ]; then


There's an open issue that coursier should run with the java runtime configured for the build (#445) I'd suggest relying on that, and then you could use $(location) to expand the location of the deploy jar in a rule or macro that writes this file.

shs96c · 2020-10-27T11:28:09Z

private/tools/java/rules/jvm/external/maven/Outdated.java

+    List<String> artifacts = Files.readAllLines(Paths.get(artifactsFilePath), StandardCharsets.UTF_8);
+    List<String> repositories = Files.readAllLines(Paths.get(repositoriesFilePath), StandardCharsets.UTF_8);
+
+    System.out.println(String.format("Checking for updates of %d artifacts against the following repositories:", artifacts.size()));


Nit: System.out.printf

I mainly kept it with String.format since it matches all of the other logging in the file that uses verboseLog instaed of System.out.println

private/tools/java/rules/jvm/external/maven/Outdated.java

jin · 2020-11-13T07:14:00Z

coursier.bzl

    artifacts = []
-    for a in repository_ctx.attr.artifacts:
-        artifacts.append(json_parse(a))
+    for artifact in repository_ctx.attr.artifacts:


In the future, please separate refactoring changes from feature changes for a smaller diff :)

jin · 2020-11-13T07:18:23Z

private/tools/java/rules/jvm/external/maven/Outdated.java

+        releaseVersion = getReleaseVersion(repository, groupId, artifactId);
+        if (releaseVersion != null) {
+          verboseLog(String.format("Found version [%s] for %s:%s in %s", releaseVersion, groupId, artifactId, repository));
+          // Should we search all repositories in the list for latest version instead of just the first


I think this is reasonable, but to reduce potential confusion, I think the repository where this lookup succeeded should be printed regardless of RJE_VERBOSE.

cheister requested review from c-parsons and jin as code owners October 12, 2020 06:51

googlebot added the cla: yes label Oct 12, 2020

cheister commented Oct 12, 2020

View reviewed changes

private/outdated.sh Outdated Show resolved Hide resolved

cheister force-pushed the add_outdated_action branch from 40f94de to edec3d4 Compare October 12, 2020 07:04

jin self-assigned this Oct 12, 2020

cheister force-pushed the add_outdated_action branch from edec3d4 to e36805e Compare October 12, 2020 16:33

cheister requested a review from shs96c as a code owner October 12, 2020 16:33

cheister force-pushed the add_outdated_action branch from e36805e to f0167ca Compare October 15, 2020 23:11

shs96c approved these changes Oct 27, 2020

View reviewed changes

cheister force-pushed the add_outdated_action branch from f0167ca to 6b9d9c6 Compare October 28, 2020 00:32

cheister commented Oct 28, 2020

View reviewed changes

private/tools/java/rules/jvm/external/maven/Outdated.java Show resolved Hide resolved

cheister commented Oct 28, 2020

View reviewed changes

private/tools/java/rules/jvm/external/maven/Outdated.java Show resolved Hide resolved

jin approved these changes Nov 13, 2020

View reviewed changes

Add @maven//:outdated to check for updated versions of artifacts

0f12829

cheister force-pushed the add_outdated_action branch from 6b9d9c6 to 0f12829 Compare November 14, 2020 21:16

cheister merged commit 1c52e73 into bazelbuild:master Nov 14, 2020

cheister deleted the add_outdated_action branch November 14, 2020 21:21

jin mentioned this pull request Jan 6, 2021

Release 4.0 #493

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add @maven//:outdated to check for updated versions of artifacts #465

Add @maven//:outdated to check for updated versions of artifacts #465

cheister commented Oct 12, 2020

cheister Oct 12, 2020

shs96c Oct 27, 2020

cheister Oct 28, 2020

cheister Oct 12, 2020

jin Nov 13, 2020

cheister Nov 14, 2020

shs96c left a comment

shs96c Oct 27, 2020

shs96c Oct 27, 2020

cheister Oct 28, 2020

jin Nov 13, 2020

jin Nov 13, 2020


		set -euo pipefail

		if [ -f "private/tools/prebuilt/outdated_deploy.jar" ]; then

Add @maven//:outdated to check for updated versions of artifacts #465

Add @maven//:outdated to check for updated versions of artifacts #465

Conversation

cheister commented Oct 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shs96c left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment