-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @maven//:outdated to check for updated versions of artifacts #465
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euo pipefail | ||
|
||
if [ -f "private/tools/prebuilt/outdated_deploy.jar" ]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if there is a better way to check if the action is running inside the rules_jvm_external repo or outside of it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's an open issue that coursier should run with the java runtime configured for the build (#445) I'd suggest relying on that, and then you could use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As far as I can tell #445 is still an open issue because JAVABASE is not exposed to repository rules. If we fix JAVABASE for the java that coursier uses we should fix it here also but I don't currently see a straightforward fix otherwise. |
||
outdated_jar_path=private/tools/prebuilt/outdated_deploy.jar | ||
else | ||
outdated_jar_path=external/rules_jvm_external/private/tools/prebuilt/outdated_deploy.jar | ||
fi | ||
|
||
java {proxy_opts} -jar $outdated_jar_path external/{repository_name}/outdated.artifacts external/{repository_name}/outdated.repositories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, please separate refactoring changes from feature changes for a smaller diff :)