feat(pin): allow only repinning the rules_jvm_external lockfile #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
reviewed
May 12, 2021
coursier.bzl
Outdated
| @@ -337,7 +337,8 @@ def _fail_if_repin_required(repository_ctx): | |||
| if not repository_ctx.attr.fail_if_repin_required: | |||
| return False | |||
|
|
|||
| return "REPIN" not in repository_ctx.os.environ.keys() | |||
| env_var_names = repository_ctx.os.environ.keys() | |||
| return "RULES_JVM_EXTERNAL_REPIN" not in env_var_names and "REPIN" not in env_var_names: | |||
There was a problem hiding this comment.
This line is causing the tests to fail because of the trailing :
Now that rules_rust and rules_jvm_external both support the same repinning method, make it possible to choose to repin a single lockfile or all lockfiles. Refs: bazelbuild/rules_rust#682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits (oldest to newest)
d49ec1f feat(pin): allow only repinning the rules_jvm_external lockfile
Now that rules_rust and rules_jvm_external both support the same
repinning method, make it possible to choose to repin a single lockfile
or all lockfiles.
Refs: bazelbuild/rules_rust#682