Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crate_universe): use REPIN or RULES_RUST_REPIN to enable pinning #682

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

gibfahn
Copy link
Contributor

@gibfahn gibfahn commented Apr 7, 2021


Commits (oldest to newest)

d73366b feat(crate_universe): use REPIN or RULES_RUST_REPIN to enable pinning

Make the pinning controlling env var match what was recently done in
rules_jvm_external (1).

You can use REPIN=1 (or any other value) to repin all your lockfiles,
or RULES_RUST_REPIN=1 (or any other value) to only repin your
rules_rust lockfiles.


Make the pinning controlling env var match what was recently done in
rules_jvm_external ([1][]).

You can use `REPIN=1` (or any other value) to repin all your lockfiles,
or `RULES_RUST_REPIN=1` (or any other value) to only repin your
rules_rust lockfiles.

[1]: https://github.com/bazelbuild/rules_jvm_external/blob/b2e061d6ceaa81d48a513530f48c2df403ba7dbc/coursier.bzl#L340
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@UebelAndre UebelAndre merged commit bbe24cd into bazelbuild:main Apr 7, 2021
@gibfahn gibfahn deleted the make_pinning_more_like_java branch April 8, 2021 12:05
@gibfahn
Copy link
Contributor Author

gibfahn commented Apr 8, 2021

Thanks for all your work on this repo @UebelAndre !

gibfahn added a commit to gibfahn/rules_jvm_external that referenced this pull request May 4, 2021
Now that rules_rust and rules_jvm_external both support the same
repinning method, make it possible to choose to repin a single lockfile
or all lockfiles.

Refs: bazelbuild/rules_rust#682
gibfahn added a commit to gibfahn/rules_jvm_external that referenced this pull request May 12, 2021
Now that rules_rust and rules_jvm_external both support the same
repinning method, make it possible to choose to repin a single lockfile
or all lockfiles.

Refs: bazelbuild/rules_rust#682
shs96c pushed a commit to bazelbuild/rules_jvm_external that referenced this pull request May 12, 2021
Now that rules_rust and rules_jvm_external both support the same
repinning method, make it possible to choose to repin a single lockfile
or all lockfiles.

Refs: bazelbuild/rules_rust#682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants