Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Set up CI and add .gitignore #1

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Set up CI and add .gitignore #1

merged 1 commit into from
Aug 30, 2017

Conversation

mattmoor
Copy link
Contributor

No description provided.

Copy link

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

- buildifier -mode=check $(find . -name WORKSPACE -type f)
- buildifier -mode=check $(find . -name '*.bzl' -type f)

# TODO(mattmoor): Run end-to-end testing against the cluster.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mattmoor mattmoor merged commit 4fe3e30 into master Aug 30, 2017
stevewolter added a commit to stevewolter/rules_k8s that referenced this pull request Jan 11, 2018
mattmoor pushed a commit that referenced this pull request Jan 11, 2018
* Make resolver a public property

* Review comments #1
mattmoor added a commit that referenced this pull request Jan 11, 2018
* Make resolver a public property

* Review comments #1
@nlopezgi nlopezgi deleted the add-ci branch November 27, 2018 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants