Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Make resolver a public property #95

Merged
merged 2 commits into from
Jan 11, 2018

Conversation

stevewolter
Copy link

@stevewolter stevewolter commented Jan 11, 2018

The custom resolver mattmoor@ mentioned seems to be a very workable solution for endpoint resolving (#88). I've made a PoC implementation in http://shortn/_0SyJs3BlK7 (Google-internal link) that uses a custom resolver to resolve endpoint versions after Docker digests were resolved. Could you PTAL?

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@stevewolter
Copy link
Author

I signed it!

Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this LGTM.

Travis will fail because this isn't from a branch on the main repo and so it doesn't hand out the secrets (bad design!).

Generally the process (which I will handle, but FYI) is to merge the PR into a branch of the main repo, then open a second PR to merge it into mainline (which will run integration testing properly).

A few minor comments below.

README.md Outdated
)
```

This script needs to invoke the default resolver (`//k8s:resolver`) with all its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that this script may need to invoke the default resolver, if the template may also contain image references.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -173,7 +173,7 @@ _common_attrs = {
# This is only needed for describe.
"kind": attr.string(),
"image_chroot": attr.string(),
"_resolver": attr.label(
"resolver": attr.label(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the k8s_object signature documentation at the bottom of the README.md?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@stevewolter
Copy link
Author

Thanks for the review! I addressed the minor comments. Let me know if there's anything else I need to be doing.

@mattmoor mattmoor changed the base branch from master to public-resolver January 11, 2018 16:38
@mattmoor mattmoor merged commit 0e28d11 into bazelbuild:public-resolver Jan 11, 2018
mattmoor added a commit that referenced this pull request Jan 11, 2018
* Make resolver a public property

* Review comments #1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants