Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Add --allow_unused_images resolver flag (#161) #162

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Add --allow_unused_images resolver flag (#161) #162

merged 4 commits into from
Jul 24, 2018

Conversation

calder
Copy link
Contributor

@calder calder commented Jul 16, 2018

This fixes #161.

@calder
Copy link
Contributor Author

calder commented Jul 17, 2018

@fejta @nlopezgi: Friendly ping. :-)

@fejta
Copy link
Contributor

fejta commented Jul 18, 2018

/assign
Replied on the issue

@calder
Copy link
Contributor Author

calder commented Jul 18, 2018

@fejta: Thanks! Rereplied on the issue. :-)

@calder
Copy link
Contributor Author

calder commented Jul 21, 2018

@fejta @nlopezgi: Friendly ping!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@fejta
Copy link
Contributor

fejta commented Jul 23, 2018

/ok-to-test
/lgtm

@fejta
Copy link
Contributor

fejta commented Jul 23, 2018

/override cla/google
(false-positive from my updating the branch)

@fejta
Copy link
Contributor

fejta commented Jul 23, 2018

/override cla/google

@k8s-ci-robot
Copy link

@fejta: Overrode contexts on behalf of fejta: cla/google

In response to this:

/override cla/google

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta
Copy link
Contributor

fejta commented Jul 23, 2018

/approve

@nlopezgi
Copy link
Contributor

/test pull-rules-k8s-e2e

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 23, 2018
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calder, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta commented Jul 23, 2018

/override cla/google

@k8s-ci-robot
Copy link

@fejta: Overrode contexts on behalf of fejta: cla/google

In response to this:

/override cla/google

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta
Copy link
Contributor

fejta commented Jul 23, 2018

/lgtm

@nlopezgi nlopezgi merged commit 7545f38 into bazelbuild:master Jul 24, 2018
@calder
Copy link
Contributor Author

calder commented Jul 25, 2018

Thanks @fejta!

ymotongpoo added a commit to ymotongpoo/rules_k8s that referenced this pull request Apr 9, 2020
* `resolver_args` was introduced in bazelbuild#162 but not documented
alex1545 added a commit that referenced this pull request Apr 16, 2020
* Add description on `resolver_args` for `k8s_object`

* `resolver_args` was introduced in #162 but not documented

* Fix format from pre to code

Co-authored-by: alex1545 <42874203+alex1545@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --allow_unused_images resolver flag
5 participants