Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Arbitrary args for kubectl #224

Merged
merged 12 commits into from
Nov 10, 2018
Merged

Arbitrary args for kubectl #224

merged 12 commits into from
Nov 10, 2018

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Nov 10, 2018

Trying this PR to replace all other PRs discussed in #209.
With this PR:

  • users can add args (string list) to their k8s_deploy object
  • users can use bazel run <target> -- <extra args>
  • modified templates so the kubectl command is printed out when running bazel run , useful for validation in e2e tests

Hope this satisfies everyone's needs.
fyi @chrislovecnm @Globegitter @omadawn

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 10, 2018

Can users have both args defined in the BUILD fuel and pass in args in the cli?

@nlopezgi
Copy link
Contributor Author

Can users have both args defined in the BUILD fuel and pass in args in the cli?

Yes, in the e2e tests I added both verification for use of args in the attrs defined in the BUILD file as well as one for use of bazel run --
(still fixing the tests/templats to get this working properly)

@chrislovecnm
Copy link
Contributor

You gonna rebase? Ping me when the tests are happy and I will merge ;)

@nlopezgi
Copy link
Contributor Author

alright, that was fun to debug. Tests are passing now, ptal.

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 10, 2018

Harping on this, but do we want to squash the commits on merging? I like to keep master clean so we can easily back out a PR.

I prefer when the PR owner squashed there commits into units of work.

@nlopezgi
Copy link
Contributor Author

its set up for squash and merge, so it'll be 1 commit only

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrislovecnm chrislovecnm merged commit ec388fb into bazelbuild:master Nov 10, 2018
samschlegel added a commit to discord/rules_k8s that referenced this pull request Nov 14, 2018
samschlegel added a commit to discord/rules_k8s that referenced this pull request Nov 14, 2018
nlopezgi pushed a commit that referenced this pull request Nov 16, 2018
* Pass through arguments

* Add e2e-test based on #224
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants