Arbitrary arguments for k8s_objects

[samschlegel]

This builds on #224 by passing through arguments to the individual runs

What would be the best way to test this?

[k8s-ci-robot]

Hi @samschlegel. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nlopezgi]

Hi @samschlegel ,
thanks for sending this PR.
To test this you could add to https://github.com/bazelbuild/rules_k8s/blob/master/examples/todocontroller/e2e-test.sh the same functionality like the one I added in #224 to https://github.com/bazelbuild/rules_k8s/blob/master/examples/hellohttp/e2e-test.sh to perform checks. Then add a test like https://github.com/bazelbuild/rules_k8s/blob/master/examples/hellohttp/e2e-test.sh#L118 in https://github.com/bazelbuild/rules_k8s/blob/master/examples/todocontroller/e2e-test.sh that runs "bazel run examples/todocontroller: everything -- -v=2" and checks the command(s) executed (should be printed as a result of the changes in #224 in the tpl files) do(es) contain the -v=2 arg as you expect

[chrislovecnm]

/ok to test

[chrislovecnm]

/ok-to-test

[chrislovecnm]

@samschlegel to add to what Nick mentioned. Please do not enable the controller tests. We have disabled those till we work some problems out of them. You can do the run everything on the other examples.

[samschlegel]

So I should add them to todocontroller, but not enable the tests?

[samschlegel]

It looks like hellogrpc also uses k8s_objects, so I could do it there instead.

[chrislovecnm]

@samschlegel a grpc test would be great!

[samschlegel]

Test added!

[chrislovecnm]

Can you rebase?

[chrislovecnm]

Test comment

[chrislovecnm]

Not sure if this is your test, but we have two —v on it

[samschlegel]

I just copied how @nlopezgi did the e2e test in hellohttp

[nlopezgi]

yeah, I dont know much about what valid args to pass, this is just testing that the arg set in the build file and the one set in the bazel run command both get passed through to the script, this doesnt really test the args actually do something meaningful

[nlopezgi]

ugh, mac builds are timing out pulling images, will have to figure out tomorrow what's the problem

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, samschlegel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nlopezgi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment