Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version kotlinc plugins by major version to handle API changes. #1011

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

restingbull
Copy link
Collaborator

@restingbull restingbull commented Aug 13, 2023

Part one of two.

@nkoroste discovered we had been breaking backwards compatibility by updating the plugins as the compiler plugin api changes.

These separates and compiles each major version of the compiler plugins. The follow up pr will choose the correct plugin for the toolchain -- separating the efforts made sense form a complexity and limiting the scope of the PR point of view.

Allows reuse when defining kotlinc versions. Supporting multiple plugin apis will require supporting multiple kotlincs.
Managing multiple kotlinc version increases toil. To simplify things, introduce a centralized list of the support versions of kotlinc. Success for this is predicated on the plugin api remaining stable on point releases, which is anecdotally true.
This provides a separate plugin for each major kotlinc release. Still requires wiring into the toolchain system (follow up PR), but simplifies using older versions of kotlin with less effort.
@restingbull restingbull changed the title Restingbull/998 version plugins Version kotlinc plugins by major version to handle API changes. Aug 13, 2023
Current stardoc cannot seem to handle dynamic key in dictionary comprehensions. The simple solution is to separate the KOTLINC_INDEX from the compiler repository definition. Has the added benefit of keeping development logic from production logic.
This was apparently skipped on previous passes.
@restingbull restingbull marked this pull request as ready for review August 13, 2023 23:54
release = "1.6.21",
sha256 = "632166fed89f3f430482f5aa07f2e20b923b72ef688c8f5a7df3aa1502c6d8ba",
),
],
KSP_CURRENT_COMPILER_PLUGIN_RELEASE = version(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KSP also needs to be versioned to the Kotlin compiler.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is going to be fun.

@restingbull
Copy link
Collaborator Author

@Bencodes -- Looks like we do have folks working with older versions: #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants