Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transitive_runtime_jars to KtKvmInfo #1022

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add transitive_runtime_jars to KtKvmInfo #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c564ce
Add transitive_runtime_jars to KtKvmInfo
scosenza Sep 7, 2023
85375c5
Store java_info.transitive_runtime_jars in KtJvmInfo
scosenza Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions kotlin/internal/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ KtJvmInfo = provider(
"outputs": "output jars produced by this rule. [intelij-aspect]",
"language_version": "version of kotlin used. [intellij-aspect]",
"transitive_compile_time_jars": "Returns the transitive set of Jars required to build the target. [intellij-aspect]",
"transitive_runtime_jars": "Returns the transitive set of Jars required to run the target. [intellij-aspect]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can already get this from the JavaInfo provider that will exist alongside the KtJvmInfo provider. Is that not the case?

"transitive_source_jars": "Returns the Jars containing source files of the current target and all of its transitive dependencies. [intellij-aspect]",
"annotation_processing": "Generated annotation processing jars. [intellij-aspect]",
},
Expand Down
1 change: 1 addition & 0 deletions kotlin/internal/jvm/compile.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ def kt_jvm_produce_jar_actions(ctx, rule_kind):
)],
),
transitive_compile_time_jars = java_info.transitive_compile_time_jars,
transitive_runtime_jars = java_info.transitive_runtime_jars,
transitive_source_jars = java_info.transitive_source_jars,
annotation_processing = annotation_processing,
),
Expand Down