[bzlmod] Stop relying on initialize.release.bzl #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
force-pushed
the
restingbull/fix-release
branch
from
67b17e0
to
24fc684
Compare
In order to simplify the dependency tree for the rules kotlin bootstrap, bzlmod_setup needed to be separated from the release. The reason for this is twofold: kotlin_repositories in development call kt_configure which configures released_rules_kotlin. Since bzlmod_setup is also used to load released_rules_kotlin this become a dependency cycle. Second, we don't want to load released_rules_koltin in the release module, as it is a development dependency. (whoops.) This also allows dropping a few extra bits of configuration that are unnecessary for the release.
restingbull
force-pushed
the
restingbull/fix-release
branch
from
24fc684
to
cddaeef
Compare
restingbull
requested review from
ahumesky,
cgruber,
Bencodes and
nkoroste
as code owners
Bencodes
approved these changes
Mar 12, 2024
Bencodes
pushed a commit
to Bencodes/rules_kotlin
that referenced
this pull request
Mar 13, 2024
* [bzlmod] Stop relying on initialize.release.bzl * [release] Separate bzlmod dev extensions from release extensions In order to simplify the dependency tree for the rules kotlin bootstrap, bzlmod_setup needed to be separated from the release. The reason for this is twofold: kotlin_repositories in development call kt_configure which configures released_rules_kotlin. Since bzlmod_setup is also used to load released_rules_kotlin this become a dependency cycle. Second, we don't want to load released_rules_koltin in the release module, as it is a development dependency. (whoops.) This also allows dropping a few extra bits of configuration that are unnecessary for the release.
restingbull
added a commit
that referenced
this pull request
Mar 15, 2024
* [bzlmod] Stop relying on initialize.release.bzl * [release] Separate bzlmod dev extensions from release extensions In order to simplify the dependency tree for the rules kotlin bootstrap, bzlmod_setup needed to be separated from the release. The reason for this is twofold: kotlin_repositories in development call kt_configure which configures released_rules_kotlin. Since bzlmod_setup is also used to load released_rules_kotlin this become a dependency cycle. Second, we don't want to load released_rules_koltin in the release module, as it is a development dependency. (whoops.) This also allows dropping a few extra bits of configuration that are unnecessary for the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.