Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release the Kotlin rules in a simplified workspace relying on precompiled jars. #271

Merged
merged 12 commits into from Feb 10, 2020
Merged

Release the Kotlin rules in a simplified workspace relying on precompiled jars. #271

merged 12 commits into from Feb 10, 2020

Conversation

restingbull
Copy link
Collaborator

Minor fix for the kt_jvm_import to work with the IntelliJ Bazel Plugin (Issue: bazelbuild/intellij#1616)
Move android_sdk import to third_party
Introduce release_archive macro to package the repository
Add //:rules_kotlin_release to generate a .tgz suitable for release

TESTED: All kotlin examples.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@restingbull
Copy link
Collaborator Author

@googlebot I signed it!

Covered under the Square CLA

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cgruber
cgruber reviewed Feb 6, 2020
View reviewed changes
WORKSPACE Show resolved Hide resolved
examples/node/WORKSPACE Outdated Show resolved Hide resolved
kotlin/internal/jvm/jvm.bzl Show resolved Hide resolved
kotlin/internal/repositories/BUILD Show resolved Hide resolved
kotlin/internal/toolchains.bzl Show resolved Hide resolved
kotlin/internal/utils/packager.bzl Outdated Show resolved Hide resolved
kotlin/internal/utils/packager.bzl Show resolved Hide resolved
src/main/kotlin/BUILD Outdated Show resolved Hide resolved
src/main/kotlin/BUILD Outdated Show resolved Hide resolved
third_party/BUILD Show resolved Hide resolved
Introduce release_archive for packaging the Kotlin rules.
765c21a 
Added //:rules_kotlin_release to build a release.

Issue: bazelbuild#269 (comment)
Corbin Smith added 3 commits February 6, 2020 11:48
Move maven repo back to kotlin_repos
0c6e6ea 
Make examples use the release repository

Issue: bazelbuild#269 (comment)
Move maven repo back to kotlin_repos
7103070 
Make examples use the release repository

Issue: bazelbuild#269 (comment)
Move maven repo back to kotlin_repos
4428b16 
Make examples use the release repository
Make git ignore profiling artifacts

Issue: bazelbuild#269 (comment)
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@cgruber
Copy link
Collaborator

cgruber commented Feb 10, 2020

Note, this PR sets the stage for what will become a new way of building from head - but at this point, this PR does not require such changes.

@cgruber cgruber merged commit ae70089 into bazelbuild:master Feb 10, 2020
@cgruber cgruber mentioned this pull request Feb 10, 2020
Merged
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Feb 10, 2020
@cgruber
Merge remote-tracking branch 'upstream/master' into pull_in_upstream
7d2b160 
* upstream/master:
  typo and add missing paren.
  Add release legacy-1.3.0
  Reference proper "current release" as legacy 1.3.0
  Update README to account for legacy-1.3.0 release.
  Fix bad date in changelog
  Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271)
  Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272)
  Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259)
  Add a link to the generated documentation (bazelbuild#237)
  Stop using native java rules (bazelbuild#258)
  Add InteliiJ aspect info (bazelbuild#242)
  Change readme file formatting (bazelbuild#243)
  Update CHANGELOG.md
  Update readme to release candidate 4
  Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257)
  Passthrough tags to the container android_library (bazelbuild#255)
  Fix current "latest" to actually be the latest.
  Update CHANGELOG.md
  Update to release legacy-1.3.0-rc3
  Support more recent java versions in the kotlin toolchain. (bazelbuild#236)
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Feb 10, 2020
@cgruber
Merge remote-tracking branch 'upstream/master' into really_update_fro…
c64bff7 
…m_upstream

* upstream/master:
  typo and add missing paren.
  Add release legacy-1.3.0
  Reference proper "current release" as legacy 1.3.0
  Update README to account for legacy-1.3.0 release.
  Fix bad date in changelog
  Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271)
  Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272)
  Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259)
  Add a link to the generated documentation (bazelbuild#237)
@restingbull restingbull deleted the release-binary-pkg branch February 18, 2020 22:50
cromwellian pushed a commit to cromwellian/rules_kotlin that referenced this pull request Mar 7, 2020
@restingbull @cromwellian
Release the Kotlin rules in a simplified workspace relying on precomp…
c146104 
…iled jars. (bazelbuild#271)

* Add work around for Intellij SrcJar bug: github.com/bazelbuild/intellij/issues/1616

* Move android_sdk to 3rd_party

Move toolchain configuration to the toolchains.bzl

Issue: bazelbuild#269 (comment)

* Introduce release_archive for packaging the Kotlin rules.

Added //:rules_kotlin_release to build a release.

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository
Make git ignore profiling artifacts

Issue: bazelbuild#269 (comment)

* Apply buildifier and update reflow_skylark script to run.

* Removed extranous visibility.

* Fixing merge errors in packager.bzl

* build the release in the parent directory.

* rename to retry presubmit

* fix accidental target rename.
@Kernald Kernald mentioned this pull request Mar 23, 2020
Closed
jongerrish added a commit to jongerrish/rules_kotlin that referenced this pull request Apr 16, 2020
@jongerrish
Release the Kotlin rules in a simplified workspace relying on precomp…
f17d0b6 
…iled jars. (bazelbuild#271)

* Add work around for Intellij SrcJar bug: github.com/bazelbuild/intellij/issues/1616

* Move android_sdk to 3rd_party

Move toolchain configuration to the toolchains.bzl

Issue: bazelbuild#269 (comment)

* Introduce release_archive for packaging the Kotlin rules.

Added //:rules_kotlin_release to build a release.

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository
Make git ignore profiling artifacts

Issue: bazelbuild#269 (comment)

* Apply buildifier and update reflow_skylark script to run.

* Removed extranous visibility.

* Fixing merge errors in packager.bzl

* build the release in the parent directory.

* rename to retry presubmit

* fix accidental target rename.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgruber cgruber cgruber approved these changes

@djwhang djwhang Awaiting requested review from djwhang

@git-str git-str Awaiting requested review from git-str

@jin jin Awaiting requested review from jin

@thomaswk thomaswk Awaiting requested review from thomaswk

@timpeut timpeut Awaiting requested review from timpeut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@restingbull @googlebot @cgruber