Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect fails consuming JavaInfo without srcjar. #1616

Closed
corbinrsmith opened this issue Feb 3, 2020 · 1 comment · Fixed by bazelbuild/rules_kotlin#276
Closed

Aspect fails consuming JavaInfo without srcjar. #1616

corbinrsmith opened this issue Feb 3, 2020 · 1 comment · Fixed by bazelbuild/rules_kotlin#276
Labels
lang: kotlin Kotlin rules integration product: IntelliJ IntelliJ plugin type: bug

Comments

@corbinrsmith
Copy link

The Intellij aspect expects srcjar to always be populated if it exists on a provider.

Version:
2019.10.21.0.0-6823f76

Reproduce:
Checkout https://github.com/bazelbuild/rules_kotlin/tree/legacy-1.3.0-rc4
Import .bazelproject
Sync.

Error:

Invalid text format, expected a struct, a dict, a string, a bool, or an int but got a NoneType for list element in struct field 'source_jars'
ERROR: /private/var/tmp/_bazel_corbin/114e49ea5d3cfb003df75c89cfe9d5ed/external/com_github_jetbrains_kotlin/BUILD.bazel:39:5: in @intellij_aspect//:intellij_info_bundled.bzl%intellij_info_aspect aspect on kt_jvm_import rule @com_github_jetbrains_kotlin//:kotlin-annotation-processing: 
Traceback (most recent call last):
	File "/private/var/tmp/_bazel_corbin/114e49ea5d3cfb003df75c89cfe9d5ed/external/com_github_jetbrains_kotlin/BUILD.bazel", line 39
		@intellij_aspect//:intellij_info_bundled.bzl%intellij_info_aspect(...)
	File "/private/var/tmp/_bazel_corbin/114e49ea5d3cfb003df75c89cfe9d5ed/external/intellij_aspect/intellij_info_bundled.bzl", line 54, in _aspect_impl
		intellij_info_aspect_impl(<3 more arguments>)
	File "/private/var/tmp/_bazel_corbin/114e49ea5d3cfb003df75c89cfe9d5ed/external/intellij_aspect/intellij_info_impl.bzl", line 933, in intellij_info_aspect_impl
		ctx.actions.write(ide_info_file, <1 more arguments>)
	File "/private/var/tmp/_bazel_corbin/114e49ea5d3cfb003df75c89cfe9d5ed/external/intellij_aspect/intellij_info_impl.bzl", line 933, in ctx.actions.write
		info.to_proto()
restingbull pushed a commit to restingbull/rules_kotlin that referenced this issue Feb 5, 2020
Add work around for Intellij SrcJar bug: github.com/bazelbuild/intell…
4eb5d2c 
…ij/issues/1616
@restingbull restingbull mentioned this issue Feb 5, 2020
Merged
cgruber pushed a commit to bazelbuild/rules_kotlin that referenced this issue Feb 10, 2020
@restingbull
Release the Kotlin rules in a simplified workspace relying on precomp…
ae70089 
…iled jars. (#271)

* Add work around for Intellij SrcJar bug: github.com/bazelbuild/intellij/issues/1616

* Move android_sdk to 3rd_party

Move toolchain configuration to the toolchains.bzl

Issue: #269 (comment)

* Introduce release_archive for packaging the Kotlin rules.

Added //:rules_kotlin_release to build a release.

Issue: #269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: #269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: #269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository
Make git ignore profiling artifacts

Issue: #269 (comment)

* Apply buildifier and update reflow_skylark script to run.

* Removed extranous visibility.

* Fixing merge errors in packager.bzl

* build the release in the parent directory.

* rename to retry presubmit

* fix accidental target rename.
cgruber added a commit to cgruber/rules_kotlin that referenced this issue Feb 10, 2020
@cgruber
Only propagate srcjar if it isn't the default empty jar added in ae70089
3718c3d 
 to fix bazelbuild/intellij#1616
@cgruber cgruber mentioned this issue Feb 10, 2020
Merged
cgruber added a commit to bazelbuild/rules_kotlin that referenced this issue Feb 18, 2020
@cgruber
Only propagate srcjar if it isn't the default empty jar added in ae70089
5e58b4b 
 to fix bazelbuild/intellij#1616 (#276)
cromwellian pushed a commit to cromwellian/rules_kotlin that referenced this issue Mar 7, 2020
@restingbull @cromwellian
Release the Kotlin rules in a simplified workspace relying on precomp…
c146104 
…iled jars. (bazelbuild#271)

* Add work around for Intellij SrcJar bug: github.com/bazelbuild/intellij/issues/1616

* Move android_sdk to 3rd_party

Move toolchain configuration to the toolchains.bzl

Issue: bazelbuild#269 (comment)

* Introduce release_archive for packaging the Kotlin rules.

Added //:rules_kotlin_release to build a release.

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository
Make git ignore profiling artifacts

Issue: bazelbuild#269 (comment)

* Apply buildifier and update reflow_skylark script to run.

* Removed extranous visibility.

* Fixing merge errors in packager.bzl

* build the release in the parent directory.

* rename to retry presubmit

* fix accidental target rename.
cromwellian pushed a commit to cromwellian/rules_kotlin that referenced this issue Mar 7, 2020
@cgruber @cromwellian
Only propagate srcjar if it isn't the default empty jar added in ae70089
d961569 
 to fix bazelbuild/intellij#1616 (bazelbuild#276)
@restingbull restingbull mentioned this issue Apr 5, 2020
Merged
cgruber added a commit to cgruber/rules_kotlin that referenced this issue Apr 14, 2020
@cgruber
Merge remote-tracking branch 'upstream/master' into merge_from_upstream
c35d806 
* upstream/master:
  Fix non-reproducible archives (bazelbuild#304)
  Adds a kt_plugin rule (bazelbuild#308)
  Ensure that KotlionBuilder workers use a clean directory for each compilation. (bazelbuild#298)
  Apply autoformatting to all files. (bazelbuild#302)
  Optional outputs (bazelbuild#291)
  Change plugins to use depsets, as opposed to lists. (bazelbuild#292)
  Add Corbin to the codeowners. (bazelbuild#293)
  Update Protobuf to 3.11.3 (bazelbuild#286)
  Remove tree artifacts (bazelbuild#287)
  Cleanup src tree (bazelbuild#288)
  Update README.md (bazelbuild#285)
  Filter non-kotlin code out of generated sources (bazelbuild#263)
  Update readme so the dev instructions highlight using a local clone (bazelbuild#283)
  Remove third_party checked in jars, and properly pull maven dependencies. (bazelbuild#279)
  Only propagate srcjar if it isn't the default empty jar added in ae70089 to fix bazelbuild/intellij#1616 (bazelbuild#276)
  Allow resources to be in a kotlin directory (bazelbuild#268)
jongerrish added a commit to jongerrish/rules_kotlin that referenced this issue Apr 16, 2020
@jongerrish
Release the Kotlin rules in a simplified workspace relying on precomp…
f17d0b6 
…iled jars. (bazelbuild#271)

* Add work around for Intellij SrcJar bug: github.com/bazelbuild/intellij/issues/1616

* Move android_sdk to 3rd_party

Move toolchain configuration to the toolchains.bzl

Issue: bazelbuild#269 (comment)

* Introduce release_archive for packaging the Kotlin rules.

Added //:rules_kotlin_release to build a release.

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository
Make git ignore profiling artifacts

Issue: bazelbuild#269 (comment)

* Apply buildifier and update reflow_skylark script to run.

* Removed extranous visibility.

* Fixing merge errors in packager.bzl

* build the release in the parent directory.

* rename to retry presubmit

* fix accidental target rename.
jongerrish added a commit to jongerrish/rules_kotlin that referenced this issue Apr 16, 2020
@jongerrish
Only propagate srcjar if it isn't the default empty jar added in ae70089
6b46da6 
 to fix bazelbuild/intellij#1616 (bazelbuild#276)
@mai93 mai93 added product: IntelliJ IntelliJ plugin lang: kotlin Kotlin rules integration type: bug labels Feb 11, 2021
richmowd411 added a commit to richmowd411/Rules-Kotlin that referenced this issue Apr 12, 2022
@richmowd411
Release the Kotlin rules in a simplified workspace relying on precomp…
35ce189 
…iled jars. (#271)

* Add work around for Intellij SrcJar bug: github.com/bazelbuild/intellij/issues/1616

* Move android_sdk to 3rd_party

Move toolchain configuration to the toolchains.bzl

Issue: bazelbuild/rules_kotlin#269 (comment)

* Introduce release_archive for packaging the Kotlin rules.

Added //:rules_kotlin_release to build a release.

Issue: bazelbuild/rules_kotlin#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild/rules_kotlin#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository

Issue: bazelbuild/rules_kotlin#269 (comment)

* Move maven repo back to kotlin_repos
Make examples use the release repository
Make git ignore profiling artifacts

Issue: bazelbuild/rules_kotlin#269 (comment)

* Apply buildifier and update reflow_skylark script to run.

* Removed extranous visibility.

* Fixing merge errors in packager.bzl

* build the release in the parent directory.

* rename to retry presubmit

* fix accidental target rename.
richmowd411 added a commit to richmowd411/Rules-Kotlin that referenced this issue Apr 12, 2022
@richmowd411
Only propagate srcjar if it isn't the default empty jar added in ae70…
1eafc3a 
…089a2f672182d55ef8cd1bd97ec6d2370d6a to fix bazelbuild/intellij#1616 (#276)
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@sgowroji sgowroji closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang: kotlin Kotlin rules integration product: IntelliJ IntelliJ plugin type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression introduced in #271 for legacy use of "jars" in kt_jvm_import cgruber/rules_kotlin
3 participants
@corbinrsmith @sgowroji @mai93