Pass compilation args using the official way #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
|
@cgruber @restingbull mind taking a quick look at this so that we can unblock Kotlin 1.5.30 and Compose? |
cgruber
reviewed
Nov 9, 2021
There was a problem hiding this comment.
This seems fine to me, but I want @restingbull to confirm it's not going to clobber or interfere with his other efforts around 1.5.
| return this | ||
| } | ||
|
|
||
| fun list(): List<String> = args.toList() |
There was a problem hiding this comment.
Probably should stick with the toList() naming pattern.
There was a problem hiding this comment.
Can't just merge it as we needed the base64 encoding for older versions of kotlinc. Currently working on a way to preserve versionsing without making too much of a mess.
There was a problem hiding this comment.
Added branch to cover pre-1.5
Not the way I would like it, but I don't want to hold up progress while I yak shave with one hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling this portion of the Kotlin 1.5.30 support out of the original PR. We should be able to merge this independently so that people can use Kotlin 1.5.30 without rules_kotlin having it as the default.
Original PR here: #588