Update Kotlin to 1.5.30 #588
Conversation
Bencodes
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
Bencodes
force-pushed
the
update-kotlin-to-1.5.30
branch
2 times, most recently
from
b453c3f
to
2b8d609
Compare
| fun list(): List<String> = args.toList() | ||
|
|
||
| fun base64Encode( | ||
| fun flagRepeated( |
There was a problem hiding this comment.
The undocumented format changed? Oh, surprise....
This will need to be pulled into the versioned repos. Lmk if you'd prefer to pass this off to me, as I haven't finished writing up how to make the versioned toolchains work.
There was a problem hiding this comment.
Sure you can take over.
Have an ETA on when the versioned toolchains will be ready? People won't be able to update Kotlin and likely Compose until this is merged.
There was a problem hiding this comment.
@Bencodes any idea if this works for 1.6-M1? https://github.com/JetBrains/kotlin/releases/tag/v1.6.0-M1 If we can stay on top of the feature previews we can hopefully get 1.6 support out in a timely manner.
There was a problem hiding this comment.
@jeffzoch In theory yes but I haven't tried yet. We are waiting on some important fixes in 1.6.0 so i'll be looking at supporting that soon.
|
@Bencodes @restingbull What do you guys think the status of this PR? are we planning to shoot for 1.6 or get this merged in the meantime so that we can start using 1.5.30? |
|
Having this before 1.6 would be quite nice given that Compose now depends on Kotlin 1.5.30. |
|
Hoping to take care of this today. Been insane on my side.
…On Mon, Oct 4, 2021 at 7:41 PM Marc Plano-Lesay ***@***.***> wrote:
Having this before 1.6 would be quite nice given that Compose now depends
on Kotlin 1.5.30.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#588 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN3VGM7LNUQ6OHO2BHUKDZDUFI3UNANCNFSM5EJRXGOA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
restingbull
force-pushed
the
update-kotlin-to-1.5.30
branch
from
1d03070
to
fd6ceb9
Compare
Rename variable for clarity. Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
force-pushed
the
update-kotlin-to-1.5.30
branch
from
23d16b7
to
336d396
Compare
Tracking the latest Kotlin 1.5.30 release and removing the deprecated plugin encoding
configurationCLI usage.