-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spdx license list #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tony, looks good overall. Just some ideas about usability, but can be put off for now.
def update_spdx_build(): | ||
"""Update //licenses/spdx/BUILD with new license kinds.""" | ||
|
||
build_path = '../../licenses/spdx/BUILD' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should update the instruction at the top of this file and in the README
to clarify that the add_license.py
script must be run from inside the admin/refresh_spdx/
directory, otherwise it will fail due to this line (at least this was the case for me when I attempted to run it from the root of the repository)
Feel free to create bugs for some of the productionization improvements. Then we won't loose them. |
Created 3 issues to represent points discussed in this review |
Fixes #11