Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildifier #456

Merged
merged 5 commits into from Dec 5, 2018
Merged

Buildifier #456

merged 5 commits into from Dec 5, 2018

Conversation

alexeagle
Copy link
Collaborator

No description provided.

@alexeagle alexeagle force-pushed the buildifier branch 2 times, most recently from 3eb3012 to 2d267a4 Compare December 5, 2018 19:51
@alexeagle
Copy link
Collaborator Author

probably want to ignore the "ran buildifier" commit when reviewing, it's just automated whitespace changes

Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeagle alexeagle merged commit 01ab48e into bazelbuild:master Dec 5, 2018
@alexeagle alexeagle deleted the buildifier branch December 5, 2018 21:56
alexeagle added a commit to alexeagle/rules_nodejs that referenced this pull request Oct 17, 2020
This is needed for compatibility with new ts_library rule impl which includes typings found in deps[] as files in the program

Closes bazelbuild#456

PiperOrigin-RevId: 253243590
alexeagle added a commit to alexeagle/rules_nodejs that referenced this pull request Oct 18, 2020
This is needed for compatibility with new ts_library rule impl which includes typings found in deps[] as files in the program

Closes bazelbuild#456

PiperOrigin-RevId: 253243590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants