Allow C/C++ sources in "perl_xs" target. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
@skeletonkey note that while this can be used as a workaround for #24, it's also a valid feature on it's own (e.g. see how |
|
@skeletonkey friendly ping. |
|
@PiotrSikora I apologize about the prolonged silence. I have not gotten anywhere with this issue. I have reached out to the PerlXS mailing list hoping that someone there will have ideas on how to move this forward. |
|
@skeletonkey friendly ping. |
|
@PiotrSikora I've taken a look and haven't been able to figure out how to fix the merge conflicts for your branch. Can you please make the minor fixes and then I can merge it. Thanks for you patience. |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
@skeletonkey Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora piotrsikora@google.com