Allow Perl source with no file extension #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add an example and a test based on |
|
@PiotrSikora I added a simple test that runs genhtml to generate a coverage report for the test itself. I barely know any Perl, so feedback is especially welcome. |
|
The CI failures are unrelated and fixed by #41. |
|
MR 41 has been merged in - please rebase |
skeletonkey
reviewed
Mar 28, 2022
fmeum
force-pushed
the
patch-1
branch
2 times, most recently
from
2e5c238
to
e5313f0
Compare
|
Looks good - but I believe you still need to rebase. |
Perl source files without a file extension are relatively common, with genhtml being an example that is very relevant to Bazel. Includes an example of a perl_binary for genhtml including a simple test.
|
It was a different buildifier issue that I introduced with this PR (and just fixed). Should be ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl source files without a file extension are relatively common (genhtml is an example).