pkg_files remove the executable permission to generated executable

[CareF]

Say I have

cc_binary(
    name = "foo",
    ....
)

pkg_files(
    name = "foo_files",
    srcs = [":foo"],  # in practice it also include other files to become a group
)

pkg_tar(
    name = "foo_tar",
    srcs = [":foo_files"],
)

The foo file in the tarball will have permission 644:

rules_pkg/pkg/mappings.bzl

Line 258 in 3917ae6

out_attributes.setdefault("mode", "0644")

It seems to me counter intuitive. Should the above line be None rather than 644? or am I misunderstood the usage of pkg_files?

[dieortin]

When adding files to a PackageFilesInfo from DefaultInfo, the executable is detected and its permissions are changed to 0755

rules_pkg/pkg/private/pkg_files.bzl

Line 411 in c53ff51

fmode = "0755" if f == the_executable else mapping_context.default_mode

I'm not sure why that wouldn't be happening here