Add architecture_file parameter to pkg_deb #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The architecture_file parameter provides an alternative to the architecture parameter where the contents of the debian package architecture are provided via a file
|
Is there a compelling need for this and an example of how you would use this? At first glance, what I would prefer is a way to get the architecture dynamically, from something like --cpu? |
|
I've opened #391 to provide more context around this change |
aiuto
approved these changes
Jul 30, 2021
|
Thanks for filing the issues. It will provide great context for an example of how Go interacts with Bazel and packaging. If you would care to write one for the examples tree, that would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELNOTES: Add
pkg_deb(architecture_file)to provide a way to set the Debian package architecture from the content of a file created at build time.