Improve handling of sub rpms. #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not create the subrpms files when we don't have to - Do not add `buildsubdir .` That seems to cause rpmbuild failures with older rpmbuild. - General cleanup: Remove tests against None which is needlessly brittle.
|
Will do. |
kellyma2
reviewed
Mar 15, 2024
|
FYI. I am waiting to hear back about @kellyma2 testing before hitting approve. |
Sorry, I think I'm ok to merge this, should have been clearer in my comments. I'm away for the week but have done some clearer tests around |
cgrindel
approved these changes
Mar 17, 2024
|
Silly me. Closed without merging. Necromerging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildsubdir .That seems to cause rpmbuild failures with older rpmbuild. It generates a cleanuprmchokes on the . and fails.This is a follow to Add pkg_sub_rpm rule for RPM subpackages #824.
@kellyma2 : Can you test this against your setup to see if the buildsubdir change breaks you?