Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pkg_rpm and pkg_subrpm to create empty RPMs #859

Merged
merged 4 commits into from
Apr 24, 2024

Commits on Apr 17, 2024

  1. Enable pkg_rpm and pkg_subrpm to create empty RPMs

    At present we fail in two ways if we try to create empty RPMs:
    
    - we expect srcs to be both non-empty and will fail if it is
      empty and we have no spec file
    
    - we don't emit anything for the `%files` block in the RPM if
      there are no actual files and rpmbuild doesn't like this
    
    This change tweaks the former condition so that srcs has to be
    non-None or we have to have a specfile, but will allow us to have an
    empty (`[]`) value for srcs.  Additionally, it injects
    `%defattr(-,root,root)` as a reasonable default for the `%files`
    blocks so as to allow rpmbuild to be happy with what we're providing.
    kellyma2 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3bd28d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Inject default file mode unconditionally

    We should be safe to inject this unconditionally instead of special
    casing on whether or not we have no actual files.
    kellyma2 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d56ba14 View commit details
    Browse the repository at this point in the history
  2. Fixup wrong append

    kellyma2 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6df525e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1dc2363 View commit details
    Browse the repository at this point in the history