Append workspace name to the runfiles directory name for pkg_files
#864
+40
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitaktif
force-pushed
the
append-workspace-name-pkg-files
branch
from
474def6
to
6164b24
Compare
|
@aiuto this should probably make it before the next release to avoid confusion. |
The test wasn't asserting anything about the destination path because it was missing the `env` positional parameter; the "assert_true" was tested against the assertion message (which always evaluates to True as a non-empty string).
Commit a811e7f recently fixed an issue where the workspace name was missing from the path for runfiles added via `pkg_tar` and some other rules. This extends the fix to `pkg_files` as well.
sitaktif
force-pushed
the
append-workspace-name-pkg-files
branch
from
6164b24
to
18db8ce
Compare
cgrindel
approved these changes
Apr 26, 2024
|
Thanks @cgrindel - I don't have write access so I'll defer merging to you. |
|
@aiuto Do you want to look at this before we merge? |
aiuto
approved these changes
May 1, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #856, which applies to most rules but
pkg_filesuses a different code path. This change applies the fix topkg_filesand adds a test to avoid future regressions.It also fixes a (silent) bug in the test logic.