fix: Ignore tempoary pyc.NNN files in wheels #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named `*.pyc.NNN`. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice. Fixes bazelbuild#1261
rickeylev
added a commit
to rickeylev/rules_python
that referenced
this pull request
Nov 6, 2023
Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR bazelbuild#1266 mostly fixed this issue, except that the glob exclude for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures. Fixes bazelbuild#1261 Work towards bazelbuild#1520
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
…1541) Part of the pyc compilation process is to create a temporary file named `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing. PR #1266 mostly fixed this issue, except that the exclude for the `.pyc.NNNN` files for an interpreter runtime's files was behind the `ignore_root_user_error` flag, which meant it wasn't always applied. This changes it to always be applied, which should eliminate the failures due to the missing NNNN files. Fixes #1261 Work towards #1520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore pyc files most everywhere (because they aren't deterministic), but part of the pyc creation process involves creating temporary files named
*.pyc.NNN. Though these are supposed to be temporary files nobody sees, they seem to get picked up by a glob somewhere, somehow. I'm unable to figure out how that is happening, but ignoring them in the glob expressions should also suffice.Fixes #1261