Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(whl_library): fix the dependency generation for multi-python depenency closures #1875

Merged
merged 4 commits into from
May 19, 2024
Merged

fix(whl_library): fix the dependency generation for multi-python depenency closures #1875

merged 4 commits into from
May 19, 2024

Commits on May 18, 2024

  1. fix(whl_library): stabilize dependency per python version handling 

    We start using the recently introduced `is_python_config_setting` to make
it possible to have a working select statement when multiple python
version selection needs to happen in a `whl_library`.

This adds further fixes so that the correct dependencies are pulled in when the
`python_version` string flag is unset thus making this implementation suitable
for `bzlmod` use case where we would use a single `whl_library` instance for
multiple python versions within the hub.

Work towards bazelbuild#735.
    @aignas
    aignas committed May 18, 2024
    Configuration menu
    Copy the full SHA
    4f238a5 View commit details
    Browse the repository at this point in the history

  2. fixup! fix(whl_library): stabilize dependency per python version hand… 

    …ling
    @aignas
    aignas committed May 18, 2024
    Configuration menu
    Copy the full SHA
    ed40f33 View commit details
    Browse the repository at this point in the history

  3. fixup more tests

    @aignas
    aignas committed May 18, 2024
    Configuration menu
    Copy the full SHA
    2ef4153 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. revert the example code

    @aignas
    aignas committed May 19, 2024
    Configuration menu
    Copy the full SHA
    41ae1a2 View commit details
    Browse the repository at this point in the history