fix: make mac zip builds work #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
bootstrap.script.default
branch
7 times, most recently
from
8559372
to
ab59868
Compare
rickeylev
changed the title
rickeylev
force-pushed
the
bootstrap.script.default
branch
3 times, most recently
from
c2eb91c
to
ef89231
Compare
rickeylev
force-pushed
the
bootstrap.script.default
branch
2 times, most recently
from
96fc926
to
f2e833a
Compare
rickeylev
force-pushed
the
bootstrap.script.default
branch
from
f2e833a
to
866d66c
Compare
aignas
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macs have an older version of
mktemp, one that doesn't support the--suffixarg. Thiscaused the combination of Macs and
--build_python_zip --bootstrap_impl=scriptto fail.To fix, remove the
--suffixarg. As far as I can tell, the suffix string,"Bazel.runfiles_", is just informational, so this is fine to remove.
Also adds tests to verify that a binary runs with/without zip and for the script
bootstrap.
Fixes #2030